| Summary: | Improve usability and fix bugs - again (patch) | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Peter Potrowl <peter017> |
| Component: | Plugin-WebService-MediaWiki | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, smit.meh |
| Priority: | NOR | ||
| Version: | 2.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kipi-plugins/9e34265acf7e2e8acddf53371534ca4b8585cc94 | Version Fixed In: | 2.8.0 |
| Sentry Crash Report: | |||
| Attachments: | Improvements described in my first post. | ||
Created attachment 72494 [details]
Improvements described in my first post.
Hi Peter, Gilles Thanks a lot for your patch. @Gilles, shall I review it and apply it to git/master or git/development/3.0.0 ? Smit It would be great if it could be released along with my previous patch: https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/43bc0cff2fbe54b76accd2b418f2c2c66b4455f6 Thanks a lot Thanks Smit to review. Please apply it to git/master. I already applied a patch from Peter for next 2.8.0. This file must be fixed for 2.8.0 too... Gilles Git commit 9e34265acf7e2e8acddf53371534ca4b8585cc94 by Smit Mehta. Committed on 16/07/2012 at 12:57. Pushed by smitmehta into branch 'master'. Applied patch by Peter Potrowl. Usability improvements and fixing minor bugs in mediaWiki export M +1 -0 .gitignore M +13 -1 mediawiki/TODO M +4 -4 mediawiki/plugin_wikimedia.cpp M +1 -1 mediawiki/plugin_wikimedia.h M +43 -20 mediawiki/wikimediajob.cpp M +187 -66 mediawiki/wmwidget.cpp M +13 -8 mediawiki/wmwidget.h M +13 -13 mediawiki/wmwindow.cpp http://commits.kde.org/kipi-plugins/9e34265acf7e2e8acddf53371534ca4b8585cc94 |
The attached patch improves the usability of the plugin and fix a few bugs: Enhancements: * The TODO file is now filled with suggestions. * The user can now modify the « Source » parameter of the image, thanks to a new field in the GUI. * The focus order of the fields is now correct for both tabs. * The user can now input categories and text that will be added to all the files and saved/restored when digiKam is closed/reopened. * The user can now upload several files with the same name using automatic numbering: "File - ##.jpg" will be transformed to "File - 01.jpg", "File - 02.jpg", etc. This has been intensively tested and works even in weird cases ("test##test##test", "#test#.jpg", etc.). * The correct file extension is automatically restored if removed, which is particularly interesting in the previous point case: "File#" becomes "File1.jpg", "File2.png", "File3.svg" according to the original extension Bugs: * The upload was failing when the file name contained spaces. Fixed. * When files were selected and then removed from the list, they were uploaded anyway! This is fixed now. * When the plugin window was closed and reopened, the fields were still displaying the previous outdated information. They are now reinitialized with the default message when the window is restored. Minor problems: * The email address of a developer was not the wanted one. Corrected. * Partial change of the name from « Wikimedia Commons » to « MediaWiki », which is more general and more correct (Commons is just one project among thousands of concerned wikis). Can you please merge this with kipi-plugins main branch? Thanks a lot! Reproducible: Always