| Summary: | Transform tool does not giving expected results | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | slawek <nezumi> |
| Component: | Tools/Transform | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | alexeyn3d, genosias, halla, info, sven.langkamp |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Other | ||
| URL: | http://img513.imageshack.us/img513/7062/kritabugtransform.jpg | ||
| Latest Commit: | http://commits.kde.org/calligra/aaec82da4ef4bfb620fcad64e34c9948786537af | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | shows the transfornation bug | ||
|
Description
slawek
2012-07-13 06:44:30 UTC
There is no attachment. Created attachment 72812 [details]
shows the transfornation bug
I can easily reproduce. Looks like only part of the transformed image is painted correctly over the original.
This is a regression from 2.4 -- probably the result of the iterator refactoring, but I'll have to git bisect to figure that out. This still works correct in 2.5, so I doubt it's the iterator refactoring (In reply to comment #1) > There is no attachment. IMHO, the author's attachment is under the "URL" link. By the way, the bug is still appears in current commit 49218e90... I also confirm it and still easy to replicate on master of today. It's make the 'Ctrl' perspective feature broken in general. It can also compute anormally long on certain deformation, and grow here in Ram exponentially ; easily to 5GB of ram incrementally by 100MB by 100MB ( compute more than 5 minutes, freezing system ; but always succeed to finish , even if result is not what widget traced ). I confirm that behavior and this is really annoying. Git commit a27ca9fc5db2c286de2c9d24e15e7b3b9e5a3394 by Dmitry Kazakov. Committed on 09/01/2013 at 16:27. Pushed by dkazakov into branch 'master'. Fixed Perspective Transform Worker to work properly 1) The class is cleaned up (use QTransform instead of explicit matrix computation) 2) The usage of split rects make the transformation very-very-very fast M +44 -72 krita/image/kis_perspectivetransform_worker.cpp M +8 -11 krita/image/kis_perspectivetransform_worker.h A +59 -0 krita/image/kis_progress_update_helper.h [License: GPL (v2+)] M +3 -39 krita/image/kis_transform_worker.cc M +93 -0 krita/image/krita_utils.cpp M +6 -0 krita/image/krita_utils.h M +6 -0 krita/image/tests/CMakeLists.txt A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_clone1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_clone1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_root_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_root_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_tmask1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/simple_transform/simple_transform_paint1_original.png A +73 -0 krita/image/tests/kis_perspective_transform_worker_test.cpp [License: GPL (v2+)] C +10 -11 krita/image/tests/kis_perspective_transform_worker_test.h [from: krita/image/krita_utils.h - 067% similarity] M +3 -89 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp M +4 -6 krita/plugins/tools/tool_transform2/kis_tool_transform.cc http://commits.kde.org/calligra/a27ca9fc5db2c286de2c9d24e15e7b3b9e5a3394 Git commit aaec82da4ef4bfb620fcad64e34c9948786537af by Inge Wallin, on behalf of Dmitry Kazakov. Committed on 09/01/2013 at 16:27. Pushed by ingwa into branch 'text-annotations-ingwa'. Fixed Perspective Transform Worker to work properly 1) The class is cleaned up (use QTransform instead of explicit matrix computation) 2) The usage of split rects make the transformation very-very-very fast M +44 -72 krita/image/kis_perspectivetransform_worker.cpp M +8 -11 krita/image/kis_perspectivetransform_worker.h A +59 -0 krita/image/kis_progress_update_helper.h [License: GPL (v2+)] M +3 -39 krita/image/kis_transform_worker.cc M +93 -0 krita/image/krita_utils.cpp M +6 -0 krita/image/krita_utils.h M +6 -0 krita/image/tests/CMakeLists.txt A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_blur1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_clone1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_clone1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_paint1_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_root_original.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_root_projection.png A +- -- krita/image/tests/data/perspective_worker_test/initial/initial_tmask1_paintDevice.png A +- -- krita/image/tests/data/perspective_worker_test/simple_transform/simple_transform_paint1_original.png A +73 -0 krita/image/tests/kis_perspective_transform_worker_test.cpp [License: GPL (v2+)] C +10 -11 krita/image/tests/kis_perspective_transform_worker_test.h [from: krita/image/krita_utils.h - 067% similarity] M +3 -89 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp M +4 -6 krita/plugins/tools/tool_transform2/kis_tool_transform.cc http://commits.kde.org/calligra/aaec82da4ef4bfb620fcad64e34c9948786537af |
