Bug 303447

Summary: libkcddb and libkcompactdisc are not required to build kscd
Product: kscd Reporter: Funda Wang <fundawang>
Component: generalAssignee: Multimedia Developers <kde-multimedia>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.5   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/kscd/11ff6cae25479828e3b39ba1a596a3ccdfa48b91 Version Fixed In: 4.10.1

Description Funda Wang 2012-07-13 02:14:55 UTC 
In CMakeLists.txt, it reads:

find_package(Libkcddb)
find_package(Libkcompactdisc)

But I cannot find any relative code in source, and the produced binary kscd does not link against above libs, either.

These two libs are not required acturally.

Reproducible: Always
Comment 1 Michael Pyne 2012-07-14 23:51:52 UTC 
Git commit 260f116e1f5d497c92094abeab86d1da4b7f2f63 by Michael Pyne.
Committed on 15/07/2012 at 01:27.
Pushed by mpyne into branch 'KDE/4.9'.

Remove references to non-required kde-mm libs.

Bug 303447 claims that libkcddb and libkcompactdisc are both not
actually used by kscd, and should be removed from CMakeLists.txt.

I've done what I can to prove the reporter wrong, including:

- Code review (looking for usage of headers from classes exported by
libkcddb and libkcompactdisc)
- Building kscd without CMake references to either lib.
- Running ldd on the resulting executable to verify the report that the
  libraries are not used by the binary.
- Actually *using* kscd (with an external CD player no less) after the
  aforementioned changes. The track list even shows up so CDDB data is
  being read from somewhere.

I'm convinced now. kscd does not directly require either libkcompactdisc
(Solid appears to be used instead) or libkcddb (MusicBrainz3 is used).
It is possible that those two libs are indirectly used but kscd doesn't
care at this point.

M  +1    -8    CMakeLists.txt
M  +0    -2    kscd.kcfg

http://commits.kde.org/kscd/260f116e1f5d497c92094abeab86d1da4b7f2f63
Comment 2 Pino Toscano 2013-02-20 10:20:22 UTC 
Git commit 11ff6cae25479828e3b39ba1a596a3ccdfa48b91 by Pino Toscano, on behalf of Michael Pyne.
Committed on 15/07/2012 at 01:27.
Pushed by pino into branch 'KDE/4.10'.

Remove references to non-required kde-mm libs.

Bug 303447 claims that libkcddb and libkcompactdisc are both not
actually used by kscd, and should be removed from CMakeLists.txt.

I've done what I can to prove the reporter wrong, including:

- Code review (looking for usage of headers from classes exported by
libkcddb and libkcompactdisc)
- Building kscd without CMake references to either lib.
- Running ldd on the resulting executable to verify the report that the
  libraries are not used by the binary.
- Actually *using* kscd (with an external CD player no less) after the
  aforementioned changes. The track list even shows up so CDDB data is
  being read from somewhere.

I'm convinced now. kscd does not directly require either libkcompactdisc
(Solid appears to be used instead) or libkcddb (MusicBrainz3 is used).
It is possible that those two libs are indirectly used but kscd doesn't
care at this point.
FIXED-IN: 4.10.1

(cherry picked from commit 260f116e1f5d497c92094abeab86d1da4b7f2f63)

Conflicts:
	CMakeLists.txt

M  +1    -8    CMakeLists.txt
M  +0    -2    kscd.kcfg

http://commits.kde.org/kscd/11ff6cae25479828e3b39ba1a596a3ccdfa48b91