Summary: | Crash on Find-Replace In Files [GrepOutputModel::doReplacements] | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Christopher Heiny <christopherheiny> |
Component: | general | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | h.p.griffiths+bugs, kde, yaroslavkishchenko |
Priority: | NOR | ||
Version: | 4.3.0 | ||
Target Milestone: | 4.3.0 | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdevplatform/3b0dba91085184a1f515044ac0149937f74d066d | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | New crash information added by DrKonqi |
Description
Christopher Heiny
2012-07-10 20:50:22 UTC
Created attachment 74758 [details]
New crash information added by DrKonqi
kdevelop (4.3.1) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1
- What I was doing when the application crashed:
repitable crash on find-replace((((((((
-- Backtrace (Reduced):
#7 0xb67fa844 in QStandardItem::rowCount (this=0x0) at .moc/release-shared/moc_qstandarditemmodel.cpp:137
#8 0xacfc7492 in GrepOutputModel::doReplacements (this=0x95b0008) at ../../../plugins/grepview/grepoutputmodel.cpp:425
#9 0xacfcf098 in GrepOutputView::onApply (this=0x95a0bb0) at ../../../plugins/grepview/grepoutputview.cpp:264
#10 0xacfbc3c8 in qt_static_metacall (_a=0xbfc63e88, _id=10, _o=0x95a0bb0, _c=<optimized out>) at moc_grepoutputview.cpp:92
#11 GrepOutputView::qt_static_metacall (_o=0x95a0bb0, _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0xbfc63e88) at moc_grepoutputview.cpp:76
Easily reproducible: Do a search via Ctrl+Alt+F that will match nothing, then enter something in the replace-box and then press the 'Replace' button. I'm on it. *** Bug 308083 has been marked as a duplicate of this bug. *** *** Bug 305026 has been marked as a duplicate of this bug. *** Git commit 3b0dba91085184a1f515044ac0149937f74d066d by Kevin Funk. Committed on 04/12/2012 at 23:36. Pushed by kfunk into branch 'master'. Do not crash in GrepOutputModel In case there are no matches you can still trigger the replace. => Crash in GrepOutputmodel because it assumes the root item of the model is still there. Fixes: * Disable the replace button in case there are no matches * Do not crash in GrepoutModel in case the root item is invalid (call safety) REVIEW: 107548 M +5 -0 plugins/grepview/grepoutputmodel.cpp M +8 -2 plugins/grepview/grepoutputview.cpp http://commits.kde.org/kdevplatform/3b0dba91085184a1f515044ac0149937f74d066d |