Bug 303213

Summary:	QML based shutdown dialog misses shadow in some places.
Product:	[Plasma] ksmserver	Reporter:	Mark <markg85>
Component:	ui	Assignee:	Lubos Lunak <l.lunak>
Status:	RESOLVED FIXED
Severity:	normal	CC:	lamarque, notmart, plasma-bugs
Priority:	NOR	Keywords:	regression
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-runtime/3508ea65f8abb1620cfa8d60d3c9e8b7cec0170c	Version Fixed In:	4.9
Attachments:	Shadow is missing in some parts

Description Mark 2012-07-08 22:10:57 UTC

Hi,

see the attachment.
Those are not missing in Qt 4.8.x and below with the QWidget based version.

Reproducible: Always

Comment 1 Mark 2012-07-08 22:11:45 UTC

Created attachment 72383 [details]
Shadow is missing in some parts

Comment 2 Lamarque V. Souza 2012-07-09 02:04:01 UTC

I think this problem is specific to your configuration. I do not have this problem here.

Comment 3 Marco Martin 2012-07-09 09:28:01 UTC

Git commit 3508ea65f8abb1620cfa8d60d3c9e8b7cec0170c by Marco Martin.
Committed on 09/07/2012 at 11:25.
Pushed by mart into branch 'KDE/4.9'.

fix shadows
FIXED-IN:4.9

M  +-    --    desktoptheme/air/dialogs/shutdowndialog.svgz

http://commits.kde.org/kde-runtime/3508ea65f8abb1620cfa8d60d3c9e8b7cec0170c

Comment 4 Marco Martin 2012-07-09 09:29:01 UTC

wasn't a regression, this problem was always there

Comment 5 Mark 2012-07-12 19:25:29 UTC

Re-opened. Issues is still clearly visible in RC 2. Just tried it.

Comment 6 Lamarque V. Souza 2012-07-13 13:24:33 UTC

I guess the fix did not make it to 4.9rc2 (it was commit at the same day the freeze for 4.9rc2 took place). Can you try copying the file mentioned in the commit and test it yourself. By the way, do not reopen a bug if a developer closed it.

Comment 7 Mark 2012-07-13 13:58:36 UTC

(In reply to comment #6)
> I guess the fix did not make it to 4.9rc2 (it was commit at the same day the
> freeze for 4.9rc2 took place). Can you try copying the file mentioned in the
> commit and test it yourself. By the way, do not reopen a bug if a developer
> closed it.

Hi,

I will test it today and report back in this report.

As for not reopening. I believe the usual approach is to reopen a bug if the issue is still visible. As it is, i reopened it. I could also fill a new bug report but that's kinda pointless if it's the same issue.

Cheers,
Mark

Comment 8 Lamarque V. Souza 2012-07-13 14:11:31 UTC

The fact is that you are not even sure you really tested the fix. Ask the developer who closed the bug how to test the fix first, if the fix really does not solve the problem then reopen the bug.

Comment 9 Mark 2012-07-13 14:43:27 UTC

Confirmed fixed.
I'd expect that the fix would have been in RC 2 since it's commited 4 days ago. RC 2 was released 2 days ago thus that made me think the fix would be in.

Either way, fixed.

Comment 10 Lamarque V. Souza 2012-07-13 14:58:33 UTC

Well, releasing huge software like KDE SC is not fast, it takes a couple of days to prepare the tarballs for each release (including each beta's and rc's). The process starts with a tagging freeze and ends with the tarballs release. In this case the freeze happened in July 9th, the day of the commit, so there was a good change the commit was not picked up to create the tarballs. Two days later 4.9rc2 was released but since the commit was not picked in the first place it does not matter how many days 4.9rc2 has been released now.

The schedule for 4.9 is here: http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule#Monday.2C_July_9.2C_2012:_KDE_4.9_Tagging_Freeze_for_Release_Candidate_2

Anything commited in the tagging day and beyond is going to enter the next release, which in this case is 4.9, that is why Marco wrote "FIXED-IN: 4.9" and not "FIXED-IN: 4.9rc2".