| Summary: | Backgrounds pixelated | ||
|---|---|---|---|
| Product: | [Applications] calligrastage | Reporter: | Jussi Schultink <jussi01> |
| Component: | general | Assignee: | T Zachmann <t.zachmann> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | cbo |
| Priority: | NOR | ||
| Version: | 2.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | http://wstaw.org/m/2012/07/05/plasma-desktopBh1841.png | ||
| Latest Commit: | http://commits.kde.org/calligra/96dcc1ea759fb84dafed9f29dba4b83c2fcb0645 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Jussi Schultink
2012-07-05 10:44:15 UTC
http://jussi01.com/upload/uploads/20120705-104555-calligraproblem.odp for doc to reproduce. I can confirm Git commit f1003bd710c27bc79af1b739c1e2ae352cfeb84f by Thorsten Zachmann. Committed on 06/07/2012 at 19:19. Pushed by zachmann into branch 'master'. Improve painting of stretched pattern background For page backgrounds it happens that the image gets shown quite badly when stretch mode is used. See bug. When tesing the fix I found out that this effects quite a lot presentations. Not all as bad as in the bug report. With the patch all the images improve nicely. Problem was that the images generated for the pattern background did not generate a image as big as needed but some fixed one that resulted in not so good looking background images. The patch is quite big as 2 new parameters (KoViewConverter and KoShapePaintingContext) are added to the KoShapeBackground::paint method. The KoShapePaintingContext is not yet used but this is needed for animations in stage that change the background color and as I was already at it I added it too. REVIEW: 105458 M +5 -1 karbon/ui/widgets/KarbonSmallStylePreview.cpp M +6 -6 kexi/plugins/shapes/relationdesign/kexirelationdesignshape.cpp M +2 -2 kexi/plugins/shapes/relationdesign/kexirelationdesignshape.h M +1 -1 libs/flake/KoColorBackground.cpp M +1 -1 libs/flake/KoColorBackground.h M +1 -1 libs/flake/KoGradientBackground.cpp M +1 -1 libs/flake/KoGradientBackground.h M +1 -1 libs/flake/KoOdfGradientBackground.cpp M +2 -2 libs/flake/KoOdfGradientBackground.h M +2 -2 libs/flake/KoPathShape.cpp M +1 -1 libs/flake/KoPathShape.h M +11 -4 libs/flake/KoPatternBackground.cpp M +1 -1 libs/flake/KoPatternBackground.h M +3 -1 libs/flake/KoShapeBackground.h M +1 -1 libs/flake/KoShapeManager.cpp M +2 -2 libs/flake/KoUnavailShape.cpp M +1 -1 libs/flake/KoUnavailShape.h M +5 -1 libs/flake/tests/TestShapeBackgroundCommand.cpp M +3 -1 libs/kopageapp/KoPAMasterPage.cpp M +6 -4 libs/kopageapp/KoPAPage.cpp M +1 -1 libs/kopageapp/KoPAPage.h M +2 -2 libs/kopageapp/KoPAPageBase.cpp M +1 -1 libs/kopageapp/KoPAPageBase.h M +3 -1 libs/kopageapp/KoPAViewModeNormal.cpp M +2 -2 plugins/artistictextshape/ArtisticTextShape.cpp M +1 -1 plugins/artistictextshape/ArtisticTextShape.h M +2 -2 plugins/chartshape/ChartShape.cpp M +2 -2 plugins/chartshape/Legend.cpp M +2 -2 plugins/chartshape/PlotArea.cpp M +5 -1 plugins/dockers/styledocker/StylePreview.cpp M +1 -1 plugins/textshape/TextShape.cpp M +3 -1 stage/part/KPrAnimationDirector.cpp M +2 -2 words/part/frames/KWFrameLayout.cpp http://commits.kde.org/calligra/f1003bd710c27bc79af1b739c1e2ae352cfeb84f Git commit 96dcc1ea759fb84dafed9f29dba4b83c2fcb0645 by Thorsten Zachmann. Committed on 06/07/2012 at 19:19. Pushed by zachmann into branch 'calligra/2.5'. Improve painting of stretched pattern background For page backgrounds it happens that the image gets shown quite badly when stretch mode is used. See bug. When tesing the fix I found out that this effects quite a lot presentations. Not all as bad as in the bug report. With the patch all the images improve nicely. Problem was that the images generated for the pattern background did not generate a image as big as needed but some fixed one that resulted in not so good looking background images. The patch is quite big as 2 new parameters (KoViewConverter and KoShapePaintingContext) are added to the KoShapeBackground::paint method. The KoShapePaintingContext is not yet used but this is needed for animations in stage that change the background color and as I was already at it I added it too. REVIEW: 105458 (cherry picked from commit f1003bd710c27bc79af1b739c1e2ae352cfeb84f) M +5 -1 karbon/ui/widgets/KarbonSmallStylePreview.cpp M +6 -6 kexi/plugins/shapes/relationdesign/kexirelationdesignshape.cpp M +2 -2 kexi/plugins/shapes/relationdesign/kexirelationdesignshape.h M +1 -1 libs/flake/KoColorBackground.cpp M +1 -1 libs/flake/KoColorBackground.h M +1 -1 libs/flake/KoGradientBackground.cpp M +1 -1 libs/flake/KoGradientBackground.h M +1 -1 libs/flake/KoOdfGradientBackground.cpp M +2 -2 libs/flake/KoOdfGradientBackground.h M +2 -2 libs/flake/KoPathShape.cpp M +1 -1 libs/flake/KoPathShape.h M +11 -4 libs/flake/KoPatternBackground.cpp M +1 -1 libs/flake/KoPatternBackground.h M +3 -1 libs/flake/KoShapeBackground.h M +1 -1 libs/flake/KoShapeManager.cpp M +2 -2 libs/flake/KoUnavailShape.cpp M +1 -1 libs/flake/KoUnavailShape.h M +5 -1 libs/flake/tests/TestShapeBackgroundCommand.cpp M +3 -1 libs/kopageapp/KoPAMasterPage.cpp M +6 -4 libs/kopageapp/KoPAPage.cpp M +1 -1 libs/kopageapp/KoPAPage.h M +2 -2 libs/kopageapp/KoPAPageBase.cpp M +1 -1 libs/kopageapp/KoPAPageBase.h M +3 -1 libs/kopageapp/KoPAViewModeNormal.cpp M +2 -2 plugins/artistictextshape/ArtisticTextShape.cpp M +1 -1 plugins/artistictextshape/ArtisticTextShape.h M +2 -2 plugins/chartshape/ChartShape.cpp M +2 -2 plugins/chartshape/Legend.cpp M +2 -2 plugins/chartshape/PlotArea.cpp M +5 -1 plugins/dockers/styledocker/StylePreview.cpp M +1 -1 plugins/textshape/TextShape.cpp M +3 -1 stage/part/KPrAnimationDirector.cpp M +2 -2 words/part/frames/KWFrameLayout.cpp http://commits.kde.org/calligra/96dcc1ea759fb84dafed9f29dba4b83c2fcb0645 |
