| Summary: | Treeview lines are not far enough from branch expanders | ||
|---|---|---|---|
| Product: | [Plasma] Oxygen | Reporter: | Ruslan Kabatsayev <b7.10110111> |
| Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | b7.10110111, hugo.pereira.da.costa, web |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Ruslan Kabatsayev
2012-07-02 11:46:21 UTC
Confirmed. Also with 'normal' expanders as far as I can tell. Also the bar is too short. Must be a regression, I'm pretty sure it was ok at some point (will double check and bisect if yes) Thanks for reporting ;) ... v1.2.1 is correct, v1.2.2 is not. So bisecting now ... commit 077db4ce21ca240ff99cdb339176adca342c28bf Author: Ruslan Kabatsayev <b7.10110111@gmail.com> Date: Thu Feb 23 20:46:22 2012 +0400 Reduce TreeView cell vertical padding in a legal way (via gtkrc) Is the bad guy. I guess this means we just should change some magic numbers in lines rendering code. will try. Provided that there is enough "space" for it (you reduced separator size from 15 to 10, which likely affects both the height -wanted- and the width -unwanted-) The other issue with your patch above is that the horizontal positioning of the expander is also inconsistent with Qt (too close from edge) which is also related. We 'might' be able to fix it by playing with gtk_tree_view_set_level_indentation( treeView, 5 ); (added to oxygentreeviewengine, say), and reposition the objects. But then the hit area for the expander might be shifted with the actual position of the expander ... ps: also not that this change was not ported to gtk3 -see gtk.css: -GtkTreeView-expander-size: 15px; which as a result, remains consistent with oxygen-qt, but might have too high treeview rows ... (did not check) all in all its a bit of a mess :) This is a BIG mess. If there were separate width & height for expander, this would be what we need. But, as for now, what if we leave the width as is, and just fix the gaps? I don't feel like returning to those oversized rows... BTW, there's some issue in oxygen-qt: the gaps between + and line above it and between + and line below it are different. Looks like top line should be longer by 1px. for Qt that might be a round by one issue between expander size and its actual rendering. Tree lines are entirely rendered by Qt. So only option is to make the expander size smaller by one unit (I think). For gtk, up to you I guess. You take care of it ? (my own solution would be to just revert the initial change, since I was personally not so annoyed by the "large" rows). OK, I'll do this. Git commit 28c7ade51284cc1ad1e6172205965f9d793eb854 by Ruslan Kabatsayev. Committed on 02/07/2012 at 18:01. Pushed by kabatsayev into branch 'master'. Fix treeview lines look with new expander-size M +4 -4 src/oxygenstyle.cpp M +8 -0 src/oxygenstylewrapper.cpp http://commits.kde.org/oxygen-gtk/28c7ade51284cc1ad1e6172205965f9d793eb854 |