Bug 302347

Summary:	Regression: battery applet no longer gets passive status when fully charges, and therefore doesn't auto-hide
Product:	[Unmaintained] plasma4	Reporter:	Christian (Fuchs) <kde>
Component:	widget-battery	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	thijs22nospam
Priority:	NOR	Keywords:	regression
Version First Reported In:	4.8.90 (beta2)
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-workspace/4af94a18f725901f0ca95575f450f2940af22d56	Version Fixed/Implemented In:	4.9
Sentry Crash Report:

Description Christian (Fuchs) 2012-06-22 12:45:12 UTC

With older versions (<= 4.8.*) of the battery applet, the battery was hidden when fully charged, AC plugged in and if it was configured to be set to auto-hidden in the systray. 

People not wanting this behaviour still have the possibility to set it to always shown or hidden in said settings, so I see this as a regression. 

Looking at the source of the device notifier, setting the state to passive on a certain condition  (e.g.: fully charged, plugged in) should solve this. 

Reproducible: Always

Steps to Reproduce:
1. Add the battery applet to systray
2. Configure it to be auto-hidden (should be the default) 
3. Charge it 100%
Actual Results:  
Battery applet is still there

Expected Results:  
Battery applet is hidden, as other plasmoids, and as it used to in 4.8

Comment 1 Thijs 2012-06-22 14:48:08 UTC

Marking as regression

Comment 2 Viranch Mehta 2012-06-24 20:09:42 UTC

Git commit 4af94a18f725901f0ca95575f450f2940af22d56 by Viranch Mehta.
Committed on 24/06/2012 at 22:06.
Pushed by viranch into branch 'master'.

Make the battery applet passive to auto hide it in
the system tray when charged to 100%
FIXED-IN: 4.9

M  +11   -0    plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml

http://commits.kde.org/kde-workspace/4af94a18f725901f0ca95575f450f2940af22d56

Comment 3 Christian (Fuchs) 2012-06-24 20:27:29 UTC

A short test (unplugging, plugging back in) looked good, 

thanks for the good work :)