| Summary: | Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Mathias Dietrich <dietrichmathias> |
| Component: | Context View/Current Track | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bigyellowcactus, e.m.a.t.i.r.o.v, lfranchi, maddiemadan, mscho527, simon.esneault, vianasw, yashladia1 |
| Priority: | NOR | ||
| Version: | 2.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/amarok/2a8cb3785e50ccb0d551442e3133ac1cc6c2e8f7 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Debug Output
Shorter output of previous attachment |
||
|
Description
Mathias Dietrich
2012-06-21 13:43:22 UTC
Actually you wish that the scrolling stops when you rate the song? But the scrolling follows the playback so why should it stop? And why would you "rate often"? I fail to see the usecase of that wish. But anyway, this is not a bug but a wish. I think you missunderstood me. It's obviously a bug, just reproduce it and then you understand it. If I have a playing songs, and the lyrics are auto-scrolling during the playback. Start to rate you playing song via Context Browser Current Track. In the same moment you rate the song, your auto-scrolling lyrics scroll a very large step down. If a user would re-rate the song again, the lyrics jump again a large step down and so on. Normally if the user would rate the song, nothing would happen to the lyrics, they would just scrolling down via auto-scrolling. It seems that the Current's Track rating inflicts the lyrics plugin somehow, which is a bug. Right, that explanation makes more sense then :) You initial description didn't talk about a jump to the bottom. I think this is more likely a bug in the Current Track applet, changing component. Could you please start amarok from a Konsole with amarok -d --nofork 2>> output.txt do only the steps above and then quit and attach the output.txt to this report. Created attachment 72119 [details]
Debug Output
One addition, it's important to wait until the auto scrolling starts.
You can not trigger the jumps when the lyrics do not auto-scroll.
Created attachment 72194 [details]
Shorter output of previous attachment
Thank you for the fast feedback. I attached a shorter output when the playing starts.
Setting status correctly. I also noticed this bug (Amarok 2.5.0 on KDE 4.8.5) reproducible with amarok 2.6 Rating using Current track on context menu interrupts autoscrolling and the lyrics are scrolled down. Using v2.6.90-26-gbcdd84c Confirmed by comment #9 Reproducible with v2.8.0 Patch created at https://git.reviewboard.kde.org/r/116641/ Please review Git commit 2a8cb3785e50ccb0d551442e3133ac1cc6c2e8f7 by Albert Astals Cid, on behalf of Yash Ladia. Committed on 04/02/2017 at 10:33. Pushed by aacid into branch 'master'. Fix Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track The bug was occuring since 'userAutoScrollOffset' and 'oldSliderPosition' were being reset when track metadata was changed. This should not happen. I split the function: 'void _trackDataChanged( Meta::TrackPtr )' into 'void _trackChanged( Meta::TrackPtr )' and 'void _trackMetadataChanged( Meta::TrackPtr )' REVIEW: 116641 M +13 -5 src/context/applets/lyrics/LyricsApplet.cpp M +3 -1 src/context/applets/lyrics/LyricsApplet.h https://commits.kde.org/amarok/2a8cb3785e50ccb0d551442e3133ac1cc6c2e8f7 |