Summary: | [PATCH] Gwenview crashes when switching to a subfolder while parent folder is loading thumbnails | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | Benni Hill <benni> |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | janforemny, kde, simonandric5, yodayado |
Priority: | NOR | ||
Version: | 2.9.0 | ||
Target Milestone: | 2.9 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/gwenview/8136f977f6ea9e75f1da201b8c7357b5f8d50da8 | Version Fixed In: | 2.9.1 |
Sentry Crash Report: | |||
Attachments: | Partially revert commit "Avoid double deletes when using ThumbnailLoadJob::exec()" |
Description
Benni Hill
2012-06-18 16:24:53 UTC
I could reproduce the crash on Kubuntu 12.10 with KDE 4.8.90. Created attachment 72133 [details]
Partially revert commit "Avoid double deletes when using ThumbnailLoadJob::exec()"
I forgot the patch.
Hi Benni, thanks for the patch, but I think I fixed it another way in d9dadb8f98ad0dab35c6a997ed5791a4258e6cb0 . Can you still reproduce the bug after this commit? (BTW: you should use http://git.reviewboard.kde.org to post patches: I am quite bad at bugzilla mail, I process reviewboard requests much faster) (In reply to comment #3) > Hi Benni, thanks for the patch, but I think I fixed it another way in > d9dadb8f98ad0dab35c6a997ed5791a4258e6cb0 . Yes, this seems to solve it. > (BTW: you should use http://git.reviewboard.kde.org to post patches: I am > quite bad at bugzilla mail, I process reviewboard requests much faster) OK, I'll use reviewboard next time. *** Bug 302881 has been marked as a duplicate of this bug. *** *** Bug 303409 has been marked as a duplicate of this bug. *** *** Bug 303743 has been marked as a duplicate of this bug. *** Looks like it is still crashing. Reopening. For me it seems to be fixed with that patch applied. Git commit 8136f977f6ea9e75f1da201b8c7357b5f8d50da8 by Aurélien Gâteau. Committed on 29/07/2012 at 01:10. Pushed by gateau into branch 'KDE/4.9'. Check mCurrentItem validity before emitting any signal with it Fix the rare case where item is reset while the thumbnail is being generated by the thumbnail thread. FIXED-IN: 2.9.1 M +12 -0 lib/thumbnailloadjob.cpp http://commits.kde.org/gwenview/8136f977f6ea9e75f1da201b8c7357b5f8d50da8 *** Bug 305185 has been marked as a duplicate of this bug. *** |