Summary: | Button resize animation does not really work | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | David Edmundson <kde> |
Component: | qml-components | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | markg85, notmart |
Priority: | NOR | ||
Version: | 4.8.80 (beta1) | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-runtime/f2c0a58fb6af341aef7b06608c2becd5ae6cf7d5 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | Possible patch |
Description
David Edmundson
2012-06-17 17:02:51 UTC
pff thank you i guess. Since i added the animation. Marco and i agreed - back then - that adding the animation gives a nice polished view to the buttons. Something that actually should be done with shaders once we can use the power of QML 2. I would like to keep it animated. Perhaps the animation needs to be a little bit different? Created attachment 71971 [details]
Possible patch
Example patch. It avoids rescaling fonts, and only animates when releasing a button.
This has the effect of making the animation more prominent. Right now when you click (at the speed someone normally clicks a button without holding) one doesn't see the full animation.
If you're at Akademy we can maybe do some actual testing on random users?
David: can you push the patch? (In reply to comment #2) > Created attachment 71971 [details] > Possible patch > > Example patch. It avoids rescaling fonts, and only animates when releasing a > button. > > This has the effect of making the animation more prominent. Right now when > you click (at the speed someone normally clicks a button without holding) > one doesn't see the full animation. > > If you're at Akademy we can maybe do some actual testing on random users? Actually, my animation was only the transition in background from normal to pressed and back. I didn't add textual animations. Nope, not going to be at akademy. It was the textual animations that people had an "issue" with. The opacity fade is great, I've just given it a bit of a tweak which actually makes it more obvious. Relevant IRC backlog: [11:46] <notmart> d_ed: the opacity animation of the surfaces should stay i think [11:46] <notmart> zooming of the font yeah, quite ugly [11:46] <d_ed> did you notice I changed that in the patch [11:47] <d_ed> I made it jump directly to "pressed" [11:47] <d_ed> but it still animates back on release [11:47] <d_ed> which means if you click for 0.0000001 seconds you still see the full releasing animation [11:48] <notmart> ah, yeah [11:48] <d_ed> if anything it makes the animation more visible. [11:48] <notmart> makes sense Will duplicate patch for ToolButton then push. (In reply to comment #5) > It was the textual animations that people had an "issue" with. The opacity > fade is great, I've just given it a bit of a tweak which actually makes it > more obvious. > > Relevant IRC backlog: > [11:46] <notmart> d_ed: the opacity animation of the surfaces should stay i > think > [11:46] <notmart> zooming of the font yeah, quite ugly > [11:46] <d_ed> did you notice I changed that in the patch > [11:47] <d_ed> I made it jump directly to "pressed" > [11:47] <d_ed> but it still animates back on release > [11:47] <d_ed> which means if you click for 0.0000001 seconds you still see > the full releasing animation > [11:48] <notmart> ah, yeah > [11:48] <d_ed> if anything it makes the animation more visible. > [11:48] <notmart> makes sense > > Will duplicate patch for ToolButton then push. Sounds like a nice improvement to me. Git commit f2c0a58fb6af341aef7b06608c2becd5ae6cf7d5 by David Edmundson. Committed on 20/06/2012 at 14:34. Pushed by davidedmundson into branch 'master'. Remove text scaling on ToolButton Reviewed-by: Marco Martin M +0 -4 plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml http://commits.kde.org/kde-runtime/f2c0a58fb6af341aef7b06608c2becd5ae6cf7d5 |