Bug 302050

Summary: Problem with adblock hiding
Product: [Applications] rekonq Reporter: sahinsureyya
Component: generalAssignee: Andrea Diamantini <adjam7>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: latest git snapshot   
Target Milestone: 0.10   
Platform: Fedora RPMs   
OS: Linux   
URL: http://kde-look.org
Latest Commit: http://commits.kde.org/rekonq/67ed4f88998e30b90cfcb93cd8e6bd7e4d0ae7bd Version Fixed In:

Description sahinsureyya 2012-06-17 12:21:13 UTC 
Some of the filtered elements are not hidden although in the adblock settings hide filtered elements option is checked. Instead, you see a frame with a picture logo.

Reproducible: Always

Steps to Reproduce:
1. Go to http://kde-look.org
2. Scroll down to the searchbox, which is located at the bottom of items listed under "Artwork" on the left side of the webpage.
3. You will see a picture logo in a frame with a text which says "Sponsoring" below the searchbox. 
Actual Results:  
This picture logo seems to be a blocked advertisement, it is filtered but not hidden.

Expected Results:  
From the rekonq adblock settings, I have checked "Hide filtered elements" option. So, I would expect that the blocked element would be hidden.

I checked the same problem with both Konqueror and Firefox; both hide the blocked advertisement in the reported website. So they are loading the website properly.
Comment 1 Andrea Diamantini 2012-06-18 14:28:10 UTC 
Let's see if I can fix it in time for 1.0...
Comment 2 Andrea Diamantini 2012-07-06 20:50:34 UTC 
Git commit 67ed4f88998e30b90cfcb93cd8e6bd7e4d0ae7bd by Andrea Diamantini.
Committed on 06/07/2012 at 22:46.
Pushed by adjam into branch 'master'.

Fix adblock hide behavior

NOTE: You'll find also some style & copyrights fixes here.
Just reenable the git hooks scripts...

M  +2    -2    kwebapp/kwebmain.cpp
M  +2    -2    kwebapp/urlresolver.h
M  +2    -2    kwebapp/webpage.cpp
M  +7    -1    src/adblock/adblockmanager.cpp
M  +1    -1    src/main.cpp
M  +2    -2    src/mainview.cpp
M  +1    -1    src/mainview.h
M  +10   -4    src/networkaccessmanager.cpp
M  +1    -1    src/networkaccessmanager.h
M  +1    -1    src/newtabpage.cpp
M  +1    -1    src/settings/settingsdialog.cpp
M  +2    -2    src/tabbar.cpp
M  +6    -5    src/urlbar/completionwidget.cpp
M  +4    -4    src/urlbar/urlbar.cpp
M  +1    -1    src/webpage.cpp
M  +4    -4    src/webview.cpp
M  +4    -4    src/webview.h

http://commits.kde.org/rekonq/67ed4f88998e30b90cfcb93cd8e6bd7e4d0ae7bd