| Summary: | MixDevice::readPlaybackOrCapture appends 'Capture' twice | ||
|---|---|---|---|
| Product: | [Applications] kmix | Reporter: | John Stanley <jpsinthemix> |
| Component: | general | Assignee: | Christian Esken <esken> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
This means in effect that capture volumes will not be restored. This bug must be fixed for KDE4.9. Git commit 1137eacf33158b55f8361d2f2ccf8ea0f0d478e7 by Christian Esken. Committed on 04/07/2012 at 00:08. Pushed by esken into branch 'master'. Fix restore of capture volumes M +0 -1 core/mixdevice.cpp http://commits.kde.org/kmix/1137eacf33158b55f8361d2f2ccf8ea0f0d478e7 Forgot to close ticket. It is fixed in trunk and 4.9 branch. |
In method MixDevice::readPlaybackOrCapture we have the code (kdemultimedia-4.8.4.new/kmix/core/mixdevice.cpp): 293 QString volstr = getVolString(chid,capture); 294 if ( capture ) volstr += "Capture"; but in method QString MixDevice::getVolString, "Capture" is already appended if needed: 336 QString MixDevice::getVolString(Volume::ChannelID chid, bool capture) 337 { 338 QString volstr (Volume::ChannelNameForPersistence[chid]); 339 if ( capture ) volstr += "Capture"; 340 return volstr; 341 } so, line 294 is not needed and causes problems by appending "Capture" twice. Reproducible: Always Steps to Reproduce: 1. See Details 2. 3. Actual Results: See Fetails Expected Results: See Details