| Summary: | theoretical configwidget leak in services | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Harald Sitter <sitter> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version: | 2.5.90 (2.6 beta) | ||
| Target Milestone: | 2.6 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/75348119fe891ceb8f9c44285847c77103dfaf1f | Version Fixed In: | 2.8 |
Git commit 75348119fe891ceb8f9c44285847c77103dfaf1f by Ralf Engels. Committed on 20/02/2013 at 21:29. Pushed by rengels into branch 'master'. Fix: theoretical configwidget leak in services Fix memory leak. Cleanup additional layouts and widgets Remove KDE logging. We have our own logging FIXED-IN: 2.8 M +3 -5 src/services/amazon/AmazonSettingsModule.cpp M +1 -10 src/services/ampache/AmpacheSettings.cpp M +3 -4 src/services/gpodder/GpodderServiceSettings.cpp M +1 -0 src/services/lastfm/LastFmServiceSettings.cpp M +2 -9 src/services/magnatune/MagnatuneSettingsModule.cpp M +2 -10 src/services/mp3tunes/Mp3tunesSettingsModule.cpp http://commits.kde.org/amarok/75348119fe891ceb8f9c44285847c77103dfaf1f |
all service kcms fail to actively recover their configwidget memory in the KCMs > m_configDialog = new Ui::Mp3tunesConfigWidget; while in practice this is no issue right now (KCM being a runtime loaded plugin it's memory is recovered when the KCM is destroyed) it would be good to have the widgets deleted as otherwise a possible switch away from KCMing the config would lead to an active leak Reproducible: Always