Bug 301253

Summary:	After inline renaming, dolphin often complains the file (with the old name) does not exist.
Product:	[Applications] dolphin	Reporter:	Jekyll Wu <adaptee>
Component:	general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arthur, eugene.shalygin+bugzilla.kde, mmodem00
Priority:	NOR	Keywords:	regression
Version:	2.0.95
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-baseapps/2e057eb6e21fe850c101a1f2bedaffd986ffdf3a	Version Fixed In:	4.9.0
Sentry Crash Report:
Attachments:	warning dialog after changing the extension of one file A archive containing a few files for reproducing the problem

Description Jekyll Wu 2012-06-06 01:26:05 UTC

Quite often, after I finish inline renaming, there will be one or even multiple warning dialogs telling me the file with the old name does not exist.  That warning is definitely true, since I have just rename that file. But that kind of warning should not appear at all at the first place.



Reproducible: Sometimes

Steps to Reproduce:
1. Select some file, then rename it (It seems more easier to reproduce when changing its extension)
Actual Results:  
Sometimes, there will be one or multiple warning dialogs telling me the the old file does not exist.

Expected Results:  
No warning at all

I will attach a screenshot to show what has happend, and some test files for easy reproducing (they seem to cause higher probability of reproducing)

Comment 1 Jekyll Wu 2012-06-06 01:31:46 UTC

Created attachment 71612 [details]
warning dialog after changing the extension of one file

In this screenshot, I have just renamed 'kcminit-xxxxx.krash" to 'kcminit-xxxxx.krashed' (just changing the extension part). Then the warning dialog appear.

Comment 2 Jekyll Wu 2012-06-06 01:39:13 UTC

Created attachment 71613 [details]
A archive containing a few files for reproducing the problem

This archive just contains three reports generated by Dr.konqi.  To reproduce, just select some file and change its extention between '.krash' and '.krashes".  That triggers the warning for me with 50% chance .

Comment 3 zless 2012-06-06 19:20:56 UTC

I confirm this with KDE 4.9 beta1.

Comment 4 Peter Penz 2012-06-07 18:22:26 UTC

*** Bug 301351 has been marked as a duplicate of this bug. ***

Comment 5 Peter Penz 2012-06-07 21:43:06 UTC

*** Bug 299075 has been marked as a duplicate of this bug. ***

Comment 6 Peter Penz 2012-06-08 14:40:26 UTC

Git commit 2e057eb6e21fe850c101a1f2bedaffd986ffdf3a by Peter Penz.
Committed on 08/06/2012 at 16:39.
Pushed by ppenz into branch 'master'.

Inline renaming fixes

- Don't use an outdated KFileItem when renaming an item more than once
- Use the same font as the view
- Don't lose the focus when an editor-popup is shown
Related: bug 299327, bug 298883
FIXED-IN: 4.9.0

M  +6    -0    dolphin/src/kitemviews/kfileitemmodel.cpp
M  +1    -0    dolphin/src/kitemviews/kstandarditemlistwidget.cpp
M  +8    -3    dolphin/src/kitemviews/private/kitemlistroleeditor.cpp
M  +21   -4    dolphin/src/views/dolphinview.cpp
M  +1    -0    dolphin/src/views/dolphinview.h

http://commits.kde.org/kde-baseapps/2e057eb6e21fe850c101a1f2bedaffd986ffdf3a