Bug 301244

Summary:	amazon store error despite being configured to none
Product:	[Applications] amarok	Reporter:	Harald Sitter <sitter>
Component:	Services/Amazon MP3 Store	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	sven
Priority:	NOR
Version First Reported In:	2.5.90 (2.6 beta)
Target Milestone:	2.6
Platform:	Ubuntu
OS:	Linux
URL:	http://wstaw.org/m/2012/06/05/plasma-desktopp19253.png
Latest Commit:	http://commits.kde.org/amarok/0799fe78267e5b858b8c0f5dc562caa89902b72d	Version Fixed/Implemented In:	2.6
Sentry Crash Report:

Description Harald Sitter 2012-06-05 21:35:13 UTC

everytime I start amarok I get an error which, according to Myriam, is coming from the amazon store

what my amarokrc has to say about that:
[Service_Amazon]
country=none

please also see linked screenshot

Reproducible: Always

Comment 1 Sven Krohlas 2012-06-07 20:22:35 UTC

Git commit 0799fe78267e5b858b8c0f5dc562caa89902b72d by Sven Krohlas.
Committed on 07/06/2012 at 22:05.
Pushed by krohlas into branch 'master'.

Amazon store: several fixes related to the config

* trivial code cleanup
* do not attempt to query the store if there is no valid config. I missed
  a corner case there
* correctly write the config if the user just presses OK when being
  presented our best guess. this is the ugliest hack I have ever written.
  Isn't there a better solution?
FIXED-IN:2.6

M  +54   -32   src/services/amazon/AmazonSettingsModule.cpp
M  +9    -6    src/services/amazon/AmazonStore.cpp

http://commits.kde.org/amarok/0799fe78267e5b858b8c0f5dc562caa89902b72d