Bug 301239

Summary:	Applications get included in All Activities by default
Product:	[Plasma] kwin	Reporter:	mokush <contact>
Component:	activities	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	annma, chanika, ivan.cukic, kde, rasasi78, thijs22nospam
Priority:	NOR	Keywords:	regression
Version:	4.8.97	Flags:	thomas.luebking: ReviewRequest+
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description mokush 2012-06-05 21:10:30 UTC

All apps are marked as as "All activities" (right click the titlebar > Activities), by default. 

When either creating a new Activity, or switching to an existing one, the currently running apps are included in the newly active activity.

This breaks important functionality, adds confusion, and forces the user to manually set the activity in which the app should reside.

The 4.8 functionality is better, since it includes the running app only in the activity it was started in.



Reproducible: Always

Steps to Reproduce:
1. Run any, multiple, apps
2. Create a new activity
Actual Results:  
Current apps running/on-screen will remain the same.

Expected Results:  
The newly created activity should not include the apps running in the previous activity, unless specifically instructed to do so (from right-click titlebar, for ex).

Comment 1 Anne-Marie Mahfouf 2012-06-06 14:57:40 UTC

Confirmed

Comment 2 mokush 2012-06-07 07:01:41 UTC

As I said above, this greatly reduces default Activity functionality, but, f this is intended behavior, please at least provide an option for it.
It could probably be placed in System Settings > Workspace Behaviour.

Comment 3 Aaron J. Seigo 2012-06-08 20:28:19 UTC

kwin manages this.

Comment 4 Thomas Lübking 2012-06-08 21:11:50 UTC

What happens here is that if you've only ONE activity (so the window was on that one as technically as well on "all") and add a second one, the window "remains" on "all" activites.
If you have a second activity (so the window was NOT on all) and add a third the window remains on only one activity.
Also new windows are not set on all activities (except when being undecorated, that is another issue)

I'm not sure whether that has changed in the past - git blame seems to say "no".
(toplevel.h ::isOnAllActivities() and workspace.cpp  if "(c->isOnActivity(activity) == was_on_activity && c->isOnAllActivities() == was_on_all)" are unchanged)

Switching activities is (for me) not or only "broken" in the same way, ie. if the window is tagged to be on all activities, that  of course means it shows up on all.

-> Ivan?

Comment 5 Thomas Lübking 2012-06-09 11:52:34 UTC

the code for this didn't seem to have changed, yet here's a patch that does not consider "the only one" "all" when adding a second activity.
https://git.reviewboard.kde.org/r/105195/

Comment 6 Thomas Lübking 2012-06-12 21:27:51 UTC

Git commit 70d72e3b4d39885ba0190439f1d68942ab94ffe9 by Thomas Lübking.
Committed on 09/06/2012 at 13:36.
Pushed by luebking into branch 'master'.

don't consider matching activity list sizes as ALL if size is "1"
REVIEW: 105195

M  +2    -1    kwin/client.cpp

http://commits.kde.org/kde-workspace/70d72e3b4d39885ba0190439f1d68942ab94ffe9

Comment 7 Thomas Lübking 2012-07-20 14:25:32 UTC

The bug is absolutely not reproducible here and the observed behavior of comment #4 is "fixed" (i don't know whether it was intended)

If you actually observe a bug and want it to be fixed you'll have to provide far better information on its conditions such as:
- how many activities to start with
- is the window already tagged "on all activities" at this time
- do applications start "on all activities" when more than one activities are present
- is this a problem with session starts only or can you:
  * login
  * run kwrite
  * add an activity
    -> kwrite is now on all activities

Comment 8 mokush 2017-11-20 09:55:46 UTC

I can no longer reproduce this on 5.11.3. It was fixed somewhere in between.

The default behaviour is to start new activities empty, and not include running apps from the current activity.