Bug 300900

Summary: LibKGAPI 0.4.0 missing cmake check for QtWebKit
Product: [Frameworks and Libraries] libkgapi Reporter: Jonathan Thomas <echidnaman>
Component: GeneralAssignee: Daniel Vrátil <dvratil>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 0.4.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 0.4.1
Sentry Crash Report:

Description Jonathan Thomas 2012-05-31 00:43:51 UTC
The current CMake stuff doesn't search for/require QtWebKit, leading to a compilation failure later on when the auth dialog tries to include QWebView. It'd be nice to catch this during the initial CMake run. :)

Reproducible: Always
Comment 1 Daniel Vrátil 2012-05-31 06:09:08 UTC
If I understand it well, it fails to report when QtWebKit (or QtWebKit-devel) is not installed in the system? When present, it builds OK for you?
Comment 2 Jonathan Thomas 2012-05-31 11:27:50 UTC
Yes, but CMake should check for its existence and warn you before it gets in to the middle of the build and fails.
Comment 3 Daniel Vrátil 2012-05-31 20:13:25 UTC
Git commit 487e210611bb8fb93ce81c8ca9bfbacdfc153523 by Dan Vrátil.
Committed on 31/05/2012 at 22:13.
Pushed by dvratil into branch 'master'.

Specify all Qt modules LibKGAPI depends on

Explicitly list all Qt modules that LibKGAPI depends on so that CMake
can report and abort if any of them is missing (especially QtWebKit, the
other modules are usualy part of Qt package).
FIXED-IN: 0.4.1

M  +2    -1    CMakeLists.txt

http://commits.kde.org/akonadi-google/487e210611bb8fb93ce81c8ca9bfbacdfc153523
Comment 4 Daniel Vrátil 2012-06-11 21:26:45 UTC
Git commit 612d3a191978946ecc3d36df3cfe2acd2ab0f8d9 by Dan Vrátil.
Committed on 31/05/2012 at 22:13.
Pushed by dvratil into branch 'LibKGAPI/0.4'.

Specify all Qt modules LibKGAPI depends on

Explicitly list all Qt modules that LibKGAPI depends on so that CMake
can report and abort if any of them is missing (especially QtWebKit, the
other modules are usualy part of Qt package).
FIXED-IN: 0.4.1

M  +2    -1    CMakeLists.txt

http://commits.kde.org/akonadi-google/612d3a191978946ecc3d36df3cfe2acd2ab0f8d9