Bug 300456

Summary:	Notes are closed during saving session. If closing session is interupted, notes stay closed.
Product:	[Unmaintained] knotes	Reporter:	Slávek Banko <slavek.banko>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kdepim/3bb390aeced1f24e9f5f389ae4ddd5df1cd191fb	Version Fixed In:	4.8.4
Sentry Crash Report:
Attachments:	Do not close notes during saving session

Description Slávek Banko 2012-05-22 14:26:43 UTC

Notes are now closed during the testing, whether it is possible to log off. However, if the log off is interrupted, notes will remain closed. Hence notes should not be closed so soon.

Steps to reproduce:
1. Create note - type some text
2. Open Kate - type some text and not save it
3. Initialize the end of the session - logout.
4. Notes are closed.
5. Kate asks to save the edited file.
6. In the Kate question select cancel closing.
7. Ending a session is interrupted.
8. But notes are already closed.

Comment 1 Slávek Banko 2012-05-22 14:48:05 UTC

Created attachment 71294 [details]
Do not close notes during saving session

This is a bug that was already in KDE3.x (and maybe even earlier). For the Trinity is patch already prepared and reported. After minor adjustments can be applied also to KDE4.x.

Comment 2 Allen Winter 2012-05-22 22:24:00 UTC

Git commit 0cb16dfc9493f42570a74ff17c57fce85655f7b4 by Allen Winter.
Committed on 23/05/2012 at 00:21.
Pushed by winterz into branch 'master'.

Do not close notes during session saving.
Thanks for the patch Slávek!
FIXED-IN: 4.8.4
MERGE: 4.8

M  +3    -0    knotes/knote.cpp

http://commits.kde.org/kdepim/0cb16dfc9493f42570a74ff17c57fce85655f7b4

Comment 3 Allen Winter 2012-05-22 22:24:43 UTC

Git commit 3bb390aeced1f24e9f5f389ae4ddd5df1cd191fb by Allen Winter.
Committed on 23/05/2012 at 00:21.
Pushed by winterz into branch 'KDE/4.8'.

Do not close notes during session saving.
Thanks for the patch Slávek!
FIXED-IN: 4.8.4
MERGE: 4.8
(cherry picked from commit 0cb16dfc9493f42570a74ff17c57fce85655f7b4)

M  +3    -0    knotes/knote.cpp

http://commits.kde.org/kdepim/3bb390aeced1f24e9f5f389ae4ddd5df1cd191fb