Summary: | crash when applying comments and keywords on a set of jpeg | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | itilo <itilo> |
Component: | Metadata-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | caulier.gilles, jeffnik, matze |
Priority: | NOR | ||
Version: | 2.6.0 | ||
Target Milestone: | --- | ||
Platform: | Mageia RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/digikam/b216e9df450869f50fbfd35e278647fb1803c70e | Version Fixed In: | 2.6.0 |
Sentry Crash Report: | |||
Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
Description
itilo
2012-05-19 10:05:57 UTC
It crash in progress manager... Gilles Caulier Thanks, very interesting backtrace: a true and classic race condition. I admit a pretty obvious mistake in the code. Git commit b216e9df450869f50fbfd35e278647fb1803c70e by Marcel Wiesweg. Committed on 19/05/2012 at 21:04. Pushed by mwiesweg into branch 'master'. Rearrange progress item operations from FileActionMgr to perform safe operations. The call to ProgressItem::advance should now return true once and only once with last item, so an (still unsafe) pointer check should not be needed. M +4 -1 NEWS M +21 -23 digikam/fileaction/fileactionimageinfolist.cpp M +6 -15 digikam/fileaction/fileactionimageinfolist.h http://commits.kde.org/digikam/b216e9df450869f50fbfd35e278647fb1803c70e I believe this crash fix must go into 2.6 final, but last-minute commits are prone to introduce final-version bugs so I would be happy if metadata editing + writing to files received some testing now with that commit included. (even more if the crash had been reproducible for anyone) reopen if still reproducible *** Bug 300330 has been marked as a duplicate of this bug. *** Created attachment 71228 [details]
New crash information added by DrKonqi
digikam (2.6.0) on KDE Platform 4.8.3 (4.8.3) "release 503" using Qt 4.8.1
- What I was doing when the application crashed:
Applying tags and description to a TIFF file using "Apply to all versions" button
-- Backtrace (Reduced):
#6 Digikam::ProgressItem::totalCompleted (this=0x0) at /home/matze/projects/digikam-sc/core/libs/progressmanager/progressmanager.cpp:260
#7 0x000000000062d8cc in Digikam::TwoProgressItemsContainer::checkFinish (this=<optimized out>, ptr=<optimized out>) at /home/matze/projects/digikam-sc/core/digikam/fileaction/fileactionimageinfolist.cpp:55
#8 0x000000000062bebe in finishedWriting (this=0x7f0ac3ffe3e0) at /home/matze/projects/digikam-sc/build/core/digikam/../../../core/digikam/fileaction/fileactionimageinfolist.h:123
#9 Digikam::FileActionMngrFileWorker::writeMetadata (this=<optimized out>, infos=..., hub=0x7f0a90003910) at /home/matze/projects/digikam-sc/core/digikam/fileaction/fileworkeriface.cpp:123
#10 0x000000000062d27a in Digikam::FileWorkerInterface::qt_static_metacall (_o=0xf15c50, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/matze/projects/digikam-sc/build/core/digikam/fileworkeriface.moc:68
Mathias, Today, Marcel has patched current git/master for this problem. Do you use current implementation ? Gilles Caulier I just updated and saw two commits from Marcel regarding this bug. The crash must have been without those patches. I'll see if I can still reproduce it. Created attachment 71252 [details]
New crash information added by DrKonqi
digikam (2.6.0) on KDE Platform 4.8.3 (4.8.3) "release 503" using Qt 4.8.1
- What I was doing when the application crashed:
Same scenario as with the last report. I checked an Marcel's recent patches are included. I can still reproduce the bug.
-- Backtrace (Reduced):
#6 Digikam::ProgressItem::totalCompleted (this=0x0) at /home/matze/projects/digikam-sc/core/libs/progressmanager/progressmanager.cpp:260
#7 0x000000000062d8cc in Digikam::TwoProgressItemsContainer::checkFinish (this=<optimized out>, ptr=<optimized out>) at /home/matze/projects/digikam-sc/core/digikam/fileaction/fileactionimageinfolist.cpp:55
#8 0x000000000062bebe in finishedWriting (this=0x7f8119be33e0) at /home/matze/projects/digikam-sc/build/core/digikam/../../../core/digikam/fileaction/fileactionimageinfolist.h:123
#9 Digikam::FileActionMngrFileWorker::writeMetadata (this=<optimized out>, infos=..., hub=0x7f80a801f780) at /home/matze/projects/digikam-sc/core/digikam/fileaction/fileworkeriface.cpp:123
#10 0x000000000062d27a in Digikam::FileWorkerInterface::qt_static_metacall (_o=0xeee840, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/matze/projects/digikam-sc/build/core/digikam/fileworkeriface.moc:68
Matthias, my commit renames the checkFinish method and totalCompleted is not called anymore from line 55: Your backtrace must be made without the fix. |