Bug 300064

Summary:	Some strange strings
Product:	[Unmaintained] telepathy	Reporter:	Frederik Schwarzer <schwarzer>
Component:	general	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, pino
Priority:	NOR
Version:	unspecified
Target Milestone:	0.4.0
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Frederik Schwarzer 2012-05-15 13:15:43 UTC

data/ktelepathy.notifyrc:458
"An incoming file transfer request has been received"
Are you really showing messages like this to the user? Why not just telling them: "$contact is sending you a file" or so? Something less abstract? Many messages sound like they are from a communication between two computer programmes. Well defined words used and very specific; but too abstract for an actual user. Is that because at that places, your are not able to be more specific?

data/ktelepathy.notifyrc:547
"Install Chatstyle Installation failed"
-Install?

account-identity-dialog.ui:57
"TextLabel"
Is that a placeholder string? If so, please see the first paragragh here https://looksblo.wordpress.com/2009/04/01/translation-is-the-art-of-failure-or-what-makes-our-lifes-hard/

appearance-config.cpp:49
"BobMarley@yahoo.com"
Not sure the exact case here, but you most likely do not want to show real email addresses of random people here.

Reproducible: Always

Comment 1 David Edmundson 2012-05-15 13:29:31 UTC

1) I agree we could make it better, but $contact is sending you a file doesn't work in this case.
These messages only appear in the notifications KCM where you're configuring what notifications to show. The title of the actual notifications that the vast majority of users will see is exactly what you said.

2) Will fix

3) Will fix

4) Will change to -> @example.com (which is reserved as not being anywhere) it's just some example messages to preview the text ui. 
Tbh, doesn't really need translating. Will QString it, and i18nc the rest.

Comment 2 David Edmundson 2012-05-15 13:39:49 UTC

Git commit c7adf1e77f8b8e74d1f59950aa7587ad65a97008 by David Edmundson.
Committed on 15/05/2012 at 15:39.
Pushed by davidedmundson into branch 'master'.

Remove translatable flag on placeholder text

M  +1    -1    src/account-identity-dialog.ui

http://commits.kde.org/telepathy-accounts-kcm/c7adf1e77f8b8e74d1f59950aa7587ad65a97008

Comment 3 David Edmundson 2012-05-15 13:40:43 UTC

Git commit db94ec8ff3f987d5ffd93bf322cd01d19383fb8d by David Edmundson.
Committed on 15/05/2012 at 15:35.
Pushed by davidedmundson into branch 'master'.

Don't mark names and email addresses in the demo chat preview to be translatable.

Also remove mention to @yahoo.com which makes header fit the rest of the content which was updated.
Reviewed-by: Martin Klapetek

M  +18   -18   config/appearance-config.cpp

http://commits.kde.org/telepathy-text-ui/db94ec8ff3f987d5ffd93bf322cd01d19383fb8d

Comment 4 Pino Toscano 2012-05-15 13:51:16 UTC

(In reply to comment #3)
> Git commit db94ec8ff3f987d5ffd93bf322cd01d19383fb8d by David Edmundson.
> Committed on 15/05/2012 at 15:35.
> Pushed by davidedmundson into branch 'master'.
> 
> Don't mark names and email addresses in the demo chat preview to be
> translatable.
> 
> Also remove mention to @yahoo.com which makes header fit the rest of the
> content which was updated.

No, this is wrong:
* translating names and emails (albeit putting them as @example.com) could help making them more natural to people of your language (would you feel better than, say, an Italian user to see English names of people? I don't think so)
* this change
| -    statusMessage.setMessage(i18n("Ted Example waves."));
| +    statusMessage.setMessage(QString::fromLatin1("Ted Example waves."));
makes the message no more traslated, see also the point above for reasons.

Comment 5 Martin Klapetek 2012-05-15 14:11:52 UTC

Git commit b5fb72f40c59b35ba42f28076ef2225598b30dca by Martin Klapetek.
Committed on 15/05/2012 at 16:05.
Pushed by mklapetek into branch 'master'.

Reword some strings

Reviewed-by: Daniele E. Domenichelli

M  +18   -18   data/ktelepathy.notifyrc

http://commits.kde.org/telepathy-common-internals/b5fb72f40c59b35ba42f28076ef2225598b30dca