Bug 300063

Summary:	Auth handler prompt dialog does not have a fixed size
Product:	[Unmaintained] telepathy	Reporter:	Daniele E. Domenichelli <ddomenichelli>
Component:	auth-handler	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED INTENTIONAL
Severity:	minor	CC:	analoguecolour, cfeck, kde
Priority:	LO	Keywords:	junior-jobs
Version:	git-latest
Target Milestone:	Future
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Daniele E. Domenichelli 2012-05-15 13:04:36 UTC

When you get several password dialogs, since the size of the dialog is not fixed, but depends from the length of the display name, you have to move the mouse and click on different places, I suggest that we set a fixed size instead, What do you think?

Comment 1 Daniele E. Domenichelli 2012-10-28 01:36:14 UTC

Does it make sense to use KPasswordDialog instead of a custom one?
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKPasswordDialog.html

Comment 2 Daniele E. Domenichelli 2012-11-02 15:16:41 UTC

(In reply to comment #1)
> Does it make sense to use KPasswordDialog instead of a custom one?
> http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKPasswordDialog.
> html

As discussed with David:
No their one is super ugly and doesn't allow us to add a save button or show the account icon.

Comment 3 Christoph Feck 2012-11-02 16:04:20 UTC

You can change the icon in KPasswordDialog. You can also specify, which additional buttons are shown (it is a KDialog subclass, after all).

And even if it could not yet do it, "they" also have a bug tracker to request missing features.

Comment 4 Daniele E. Domenichelli 2012-11-02 16:55:43 UTC

I'm sorry, that wasn't really polite.
That was extracted from a very quick discussion about the reasons why KPasswordDialog was discarded at first, but probably it wasn't investigated enough, I promise I'll investigate more...

Comment 5 Daniele E. Domenichelli 2012-11-02 22:49:49 UTC

This is the password dialog we are using now [1]. 
This is using KPasswordDialog and doing a few very nasty things to show the icon [2].
And when I say nasty I mean stuff like
QHBoxLayout *box = qobject_cast<QHBoxLayout*>(m_dialog.data()->layout()->itemAt(0)->widget()->layout()->itemAt(0)->layout());
in order to place the icon, I couldn't find a better way to do it.

I'm not an ui designer, but imho the second wastes a lot of space and has a worst alignment.
Nonetheless we could work on KPasswordDialog to make it look prettier and to have an extra pixmap for the account, and then use it... But it will take time and moreover since kdelibs is frozen, we won't be able to place the icon until kde frameworks 5 is released.

Comments?

[1]http://wstaw.org/m/2012/11/02/snapshot103.png
[2]ttp://wstaw.org/m/2012/11/02/snapshot104.png

Comment 6 David Edmundson 2012-11-03 05:03:27 UTC

Do we even know if switching to KPasswordDialog would fix the issue?

Comment 7 Daniel Cohen 2014-04-13 22:22:20 UTC

As per HIG guidelines, cutting off / abbreviating the account name is worse than expanding the dialogue box.