| Summary: | Screen Transformation not reset after using Cube Effect | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Martin Flöser <mgraesslin> |
| Component: | effects-window-management | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Flags: | mgraesslin:
ReviewRequest+
|
| Priority: | NOR | ||
| Version: | 4.8.3 | ||
| Target Milestone: | 4.8.4 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| URL: | https://git.reviewboard.kde.org/r/104918/ | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/6a950aa510e33ce77b15608f19f6032176acd1f0 | Version Fixed In: | 4.8.4 |
| Attachments: | Screenshot highlighting the issue | ||
Git commit 9417a76132b5af438d25870c479e60518d7b0270 by Martin Gräßlin. Committed on 11/05/2012 at 19:55. Pushed by graesslin into branch 'master'. Ensure ScreenTransformation matrix is reset after rendering cube Cube effect modifies the ScreenTransformation matrix. While each window resets the matrix on a global level it's not reset. That means if the last rendered window had the screen rotated the ScreenTransformation keeps the rotation even after the cube ended. This causes a rotated window in e.g. TaskbarThumbnails. REVIEW: 104918 M +7 -0 kwin/effects/cube/cube.cpp http://commits.kde.org/kde-workspace/9417a76132b5af438d25870c479e60518d7b0270 Git commit 6a950aa510e33ce77b15608f19f6032176acd1f0 by Martin Gräßlin. Committed on 11/05/2012 at 19:55. Pushed by graesslin into branch 'KDE/4.8'. Ensure ScreenTransformation matrix is reset after rendering cube Cube effect modifies the ScreenTransformation matrix. While each window resets the matrix on a global level it's not reset. That means if the last rendered window had the screen rotated the ScreenTransformation keeps the rotation even after the cube ended. This causes a rotated window in e.g. TaskbarThumbnails. Cherry-picked from 9417a76132b5af438d25870c479e60518d7b0270 FIXED-IN: 4.8.4 REVIEW: 104918 M +7 -0 kwin/effects/cube/cube.cpp http://commits.kde.org/kde-workspace/6a950aa510e33ce77b15608f19f6032176acd1f0 |
Created attachment 71037 [details] Screenshot highlighting the issue Steps to reproduce: 1. Use OpenGL 2 backend 2. Use Cube Effect 3. Trigger window thumbnails Actual result: Window thumbnails are rendered transformed Expected Result: Window thumbnails are rendered correctly