Summary: | Deform brush engine behave like if the option "Use undeformed image" is always ON, regardless of the checkbox state | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | ALeXeY <alexeyn3d> |
Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla, lukast.dev, sven.langkamp |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/7e499ddf9bcae682369a2395a6be6bb1e5d02e2a | Version Fixed In: | 2.5.2 |
Description
ALeXeY
2012-05-09 19:23:26 UTC
Hi Alexey, Thanks for your report. I can confirm the bug -- I wonder whether it is caused by my iterators ng merge last week... We will have to investigate. It might, it uses oldRawData to deform image when "Use undeformed image" is checked, rawData otherwise Yeah, and there's a bit of difference in the meaning of const/nont const and rawData and oldRawdata in the ng iterators vs the old iterators, I had to fix up issues there in other places as well. If so, it should be easy enough to fix. It was the iterators ng change: - - if (m_properties->useOldData) { - m_srcAcc->sampledOldRawData(dst); - } else { - m_srcAcc->sampledRawData(dst); - } + // here there was a switch to select between new and old sampled data, but the + // sub accessor always used a const accessor, which means that there was no + // difference. + m_srcAcc->sampledOldRawData(dst); Git commit bd42a11750417fe065067b383531c8370a7f38f6 by Lukáš Tvrdý. Committed on 30/08/2012 at 21:52. Pushed by lukast into branch 'calligra/2.5'. Fix deform brush painting Bring back some removed code from iteratorsNG porting o provide sampledRawData in KisRandomSubAccessor FIXED-IN:2.5.2 REVIEW:106222 M +28 -2 krita/image/kis_random_sub_accessor.cpp M +7 -2 krita/image/kis_random_sub_accessor.h M +14 -13 krita/plugins/paintops/deform/deform_brush.cpp http://commits.kde.org/calligra/bd42a11750417fe065067b383531c8370a7f38f6 Git commit 7e499ddf9bcae682369a2395a6be6bb1e5d02e2a by Lukáš Tvrdý. Committed on 30/08/2012 at 21:52. Pushed by lukast into branch 'master'. Fix deform brush painting Bring back some removed code from iteratorsNG porting o provide sampledRawData in KisRandomSubAccessor FIXED-IN:2.5.2 REVIEW:106222 M +28 -2 krita/image/kis_random_sub_accessor.cpp M +7 -2 krita/image/kis_random_sub_accessor.h M +14 -13 krita/plugins/paintops/deform/deform_brush.cpp http://commits.kde.org/calligra/7e499ddf9bcae682369a2395a6be6bb1e5d02e2a |