Bug 299680

Summary:	Only start parse runners if they support the given file format
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	1.4 (KDE 4.9)
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/5ff71c32f1429213c275c65d9924d88df6816137	Version Fixed In:
Sentry Crash Report:

Description Dennis Nienhüser 2012-05-09 11:42:27 UTC

<CIA-94> Bernhard Beschow master * rv4.7.95-582-g2c459fb src/ (15 files in 9 dirs)
<CIA-94> API change: ParseRunnerPlugin: remove guiString(), introduce fileFormatDescription() and fileExtensions()
<CIA-94> The pure virtual method guiString() wasn't used in Marble and was only there for historical reasons.
<CIA-94> The new pure virtual methods fileFormatDescription() and fileExtensions() represent metadata which can be used for automatic filter creation in a file open dialog.
<CIA-94> That way, the file open dialog could offer all available file formats, depending on which plugins are installed.
<CIA-94> http://commits.kde.org/marble/2c459fbf45c1fdc564bb89d60aac954706da0866
--> shentey_ (~shentey@e179137239.adsl.alicedsl.de) hat #marble betreten
<Earthwings> shentey: while you're at it, what about preventing to start a parse runner that does not support the given extension?
<Earthwings> shentey: that'd save some additional thread creation etc cost
<shentey> Earthwings: good idea, could you file a bug report, please? :)


Reproducible: Always

Comment 1 Dennis Nienhüser 2012-08-14 18:40:53 UTC

Git commit 5ff71c32f1429213c275c65d9924d88df6816137 by Dennis Nienhüser.
Committed on 14/08/2012 at 20:37.
Pushed by nienhueser into branch 'master'.

Only start a parser thread if it supports the given file extension

M  +12   -5    src/lib/MarbleRunnerManager.cpp

http://commits.kde.org/marble/5ff71c32f1429213c275c65d9924d88df6816137