Bug 299426

Summary: Shader Effects get loaded with OpenGL 1 backend
Product: [Plasma] kwin Reporter: Martin Flöser <mgraesslin>
Component: compositingAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal Keywords: regression
Priority: NOR Flags: mgraesslin: ReviewRequest+
Version First Reported In: 4.8.1   
Target Milestone: 4.8.4   
Platform: unspecified   
OS: Linux   
URL: https://git.reviewboard.kde.org/r/104848/
Latest Commit: http://commits.kde.org/kde-workspace/db42152def79381547965eaadb3771f0d2fe908c Version Fixed/Implemented In: 4.8.4
Sentry Crash Report:

Description Martin Flöser 2012-05-05 08:25:55 UTC 
Steps to reproduce:
1. Use OpenGL 1 backend
2. Activate e.g. Invert effect

Actual result:
Effect gets loaded without an error message

Expected result:
Effect gets not loaded as it is not supported and an error message is shown.

Reason for incorrect behavior:
Supported methods check for availability of GLSL, while they should test whether GL2 backend is used.
Comment 1 Martin Flöser 2012-05-05 08:26:50 UTC 
Git commit db42152def79381547965eaadb3771f0d2fe908c by Martin Gräßlin.
Committed on 04/05/2012 at 11:31.
Pushed by graesslin into branch 'KDE/4.8'.

Properly detect effects which need OpenGL 2

Effects that need GLSL require that OpenGL 2 is active.
It does not matter whether the GPU would support it if
OpenGL 2 is not used.
FIXED-IN: 4.8.4
REVIEW: 104848

M  +5    -2    kwin/effects/explosion/explosion.cpp
M  +5    -2    kwin/effects/invert/invert.cpp
M  +5    -3    kwin/effects/lookingglass/lookingglass.cpp

http://commits.kde.org/kde-workspace/db42152def79381547965eaadb3771f0d2fe908c
Comment 2 Martin Flöser 2012-05-05 08:28:30 UTC 
Git commit 302629d5889f7590c48746a8af75962a4fd977d5 by Martin Gräßlin.
Committed on 04/05/2012 at 11:31.
Pushed by graesslin into branch 'master'.

Properly detect effects which need OpenGL 2

Effects that need GLSL require that OpenGL 2 is active.
It does not matter whether the GPU would support it if
OpenGL 2 is not used.

Cherry-picked from db42152

M  +5    -2    kwin/effects/explosion/explosion.cpp
M  +5    -2    kwin/effects/invert/invert.cpp
M  +5    -3    kwin/effects/lookingglass/lookingglass.cpp

http://commits.kde.org/kde-workspace/302629d5889f7590c48746a8af75962a4fd977d5