Bug 299252

Summary:	Regression: when searching in scrollback history, the matched text sometimes loses hilighting
Product:	[Applications] konsole	Reporter:	Dima Ryazanov <dima>
Component:	history	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adaptee, flegy
Priority:	NOR
Version:	2.8.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/konsole/cc72338175bd8c08d4998de606e0a48ee9e6d54f	Version Fixed In:	4.8.4
Sentry Crash Report:
Attachments:	Some text not gighligted (e.g.: CB_Rhapsody)

Description Dima Ryazanov 2012-05-02 19:13:47 UTC

The search results randomly lose hilighting when scrolling through the history.

Reproducible: Always

Steps to Reproduce:
1. Press Ctrl-Shift-F to open the "Find" toolbar.
2. Search for a word that appears multiple times in the scrollback history. All of the matches should now be hilighted in red.
3. Click "Next" or "Previous" and scroll around.
Actual Results:  
Some text will randomly lose hilighting. Scrolling or sometimes even moving the mouse makes some text hilighted again and removes hilight from other text, and so on.

Expected Results:  
Matched text should stay hilighted the whole time.

Comment 1 Jekyll Wu 2012-05-02 19:56:08 UTC

Thanks for reporting.

I guess you are using KDE SC 4.8.x ? And are you using "fixed size scrollback" or "unlimited scrollback" ?

Comment 2 Dima Ryazanov 2012-05-02 20:11:51 UTC

Sorry, forgot to specify the version. I'm using KDE 4.8.2; it used to work in 4.7.x.

I'm using fixed size set to 10000 lines.

Comment 3 Dima Ryazanov 2012-05-02 20:30:10 UTC

Everything seems to work correctly when I switch to unlimited.
When I switch back to fixed 10000 lines, it trims the history (a different bug?) so there's nothing to scroll, but as soon as there's more output, the bug starts happening again. As far as I can tell, the end of the output that fits in the window always works correctly. (I.e., if the window is 40 lines tall, the last 40 lines always get hilighted correctly, but the rest have problems.)

Comment 4 Jekyll Wu 2012-05-17 12:14:25 UTC

Git commit f2151c5e29f13722bf00ba0fba31573211fc2e09 by Jekyll Wu.
Committed on 17/05/2012 at 13:53.
Pushed by jekyllwu into branch 'master'.

Memory-based history should save and restore the 'isRealCharacter' field

Apparently I didn't take a close look at the implementation detail of
memory-based history when I added the 'isRealCharacter' flag. That
missing information causes some wrong behaviors randomly when using
memory-based history.

This is a follow up of commit dc2b64d33(for BUG 188528)
Related: bug 294330
FIXED-IN: 4.8.4

M  +1    -0    src/History.cpp
M  +2    -0    src/History.h

http://commits.kde.org/konsole/f2151c5e29f13722bf00ba0fba31573211fc2e09

Comment 5 Jekyll Wu 2012-05-17 12:15:36 UTC

Git commit cc72338175bd8c08d4998de606e0a48ee9e6d54f by Jekyll Wu.
Committed on 17/05/2012 at 13:53.
Pushed by jekyllwu into branch 'KDE/4.8'.

Memory-based history should save and restore the 'isRealCharacter' field

Apparently I didn't take a close look at the implementation detail of
memory-based history when I added the 'isRealCharacter' flag. That
missing information causes some wrong behaviors randomly when using
memory-based history.

This is a follow up of commit dc2b64d33(for BUG 188528)
Related: bug 294330
FIXED-IN: 4.8.4
(cherry picked from commit f2151c5e29f13722bf00ba0fba31573211fc2e09)

M  +1    -0    src/History.cpp
M  +2    -0    src/History.h

http://commits.kde.org/konsole/cc72338175bd8c08d4998de606e0a48ee9e6d54f

Comment 6 Martin Flaska 2012-05-31 08:57:52 UTC

Created attachment 71459 [details]
Some text not gighligted (e.g.: CB_Rhapsody)

Using Konsole version 2.8.3. Some text loses its highlighting whilst scrolling up/down.

Comment 7 Martin Flaska 2012-05-31 08:58:19 UTC

Observed also in newer version:
Version 2.8.3
Using KDE Development Platform 4.8.3 (4.8.3)

Search pattern: "CB_Rhapsody|StreamerPlayLogic",  options: regular expression & highlight all mathes.

After tapping on scroll bar and scrolling up/down, highlighted text randomly lose its highlighting.

Comment 8 Jekyll Wu 2012-05-31 11:59:32 UTC

(In reply to comment #6)
> Created attachment 71459 [details]
> Some text not gighligted (e.g.: CB_Rhapsody)
> 
> Using Konsole version 2.8.3. Some text loses its highlighting whilst
> scrolling up/down.

Martin:

This regression has been confirmed and fiexed. Wait for another weak for KDE SC 4.8.4