| Summary: | Don't create server-side group 'Ungrouped' when removing contact from all groups | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | Martin Klapetek <mklapetek> |
| Component: | common-internals | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | 0.4.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-contact-list/6d6d00eb2721949820a3ff560671f90fb0a99563 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Martin Klapetek
2012-04-30 09:38:07 UTC
How I want this fixed:
Add an additional role to the groupsModel called "GroupNameRole".
Instead of making ungrouped a group called "Ungrouped" it becomes a group called "".
The DisplayRole returns the same as the GroupNameRole _except_ in the case where the group == "" at which point it returns i18n("Ungrouped").
the code in the contact list should always use the GroupRole when adding contacts to groups. (possibly wrap it in an "if" statement). The display will look as it does now.
This also tidies the code as it eliminates the need for that m_translatedUngrouped in the groups model.
Git commit 6d6d00eb2721949820a3ff560671f90fb0a99563 by David Edmundson. Committed on 31/05/2012 at 00:00. Pushed by davidedmundson into branch 'master'. Use GroupNameRole and DisplayRole for groups model correctly. Do not try and add someone to "ungrouped" group Reviewed-by: Martin Klapetek M +1 -1 abstract-contact-delegate.cpp M +5 -3 contact-list-widget.cpp http://commits.kde.org/telepathy-contact-list/6d6d00eb2721949820a3ff560671f90fb0a99563 |