Summary: | When deleting the current item, the new current item is not underlined in the view | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Frank Reininghaus <frank78ac> |
Component: | view-engine: general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e | Version Fixed In: | 4.8.3 |
Sentry Crash Report: |
Description
Frank Reininghaus
2012-04-25 06:59:38 UTC
Git commit 68ce395a192362969783615e50a8004d3029eb7e by Frank Reininghaus. Committed on 25/04/2012 at 09:01. Pushed by freininghaus into branch 'KDE/4.8'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 297488 FIXED-IN: 4.8.3 REVIEW: 104709 M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +10 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp http://commits.kde.org/kde-baseapps/68ce395a192362969783615e50a8004d3029eb7e Git commit 922742762f2b1655ba55756b590e327acb00ce77 by Frank Reininghaus. Committed on 25/04/2012 at 09:20. Pushed by freininghaus into branch 'master'. When the current item is removed, make -1 the current index temporarily This fixes two problems: 1. KItemListKeyboardSearchManger can cancel the current search when a new folder is opened (note that this action removes the current item from the view). 2. The view can underline the new current item (which is the item that used to be below the removed item). Note that this did not work before because the view did not receive a currentChanged() signal in this case and therefore did not update the "current item" status of the new current item. Related: bug 297488 REVIEW: 104709 (cherry picked from commit 68ce395a192362969783615e50a8004d3029eb7e) M +2 -0 dolphin/src/kitemviews/kitemlistcontroller.cpp M +6 -3 dolphin/src/kitemviews/kitemlistselectionmanager.cpp M +10 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp M +4 -0 dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h http://commits.kde.org/kde-baseapps/922742762f2b1655ba55756b590e327acb00ce77 |