| Summary: | DAV not working if using Swedish locale | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] Akonadi | Reporter: | Michael Rydén <zynex> |
| Component: | DAV Resource | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | aleh, cyberbat83, flyser42, greg, itumaykin+kde, m407, t.kijas, urkud |
| Priority: | NOR | ||
| Version: | 4.8 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| URL: | https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/914040 | ||
| Latest Commit: | http://commits.kde.org/kdepim-runtime/962e8c301e2c90e9caaeabbddfcb5c0e0eaf03a3 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Can't click this if using Swedish locale
Fix protocolName translation |
||
|
Description
Michael Rydén
2012-04-24 10:49:30 UTC
Created attachment 70626 [details]
Can't click this if using Swedish locale
Just installed Precise, same problem there. *** Bug 289399 has been marked as a duplicate of this bug. *** I've tested with KDE 4.9.2 under OpenSuse and everything is working fine with the Swedish locale. Can you confirm that this issue is still present for you? Since Kubuntu 12.10, the way of accessing Google data has changed, so i don't use DAV to access calendar any more. So at this point I can't confim if this has been fixed in the recent update. OK, I'll leave this bug open for now however just in case. Bug exists on KDE 4.9.2 openSUSE 12.2 Russian locale. Just want to add some details. I'm trying to use DAV with the latest ownCloud 4.5.1. CalDAV resource after creation and reopenning settings dialog becomes a CarDAV and it is not possible to edit this thing. I confirm this with KDE SC 4.9.3 and owncloud 4.5.3. Running Gentoo amd64 with Russian locale. (In reply to comment #9) > I confirm this with KDE SC 4.9.3 and owncloud 4.5.3. Running Gentoo amd64 > with Russian locale. And after removing kdepim-l10n package caldav appears as caldav and carddav appears as carddav opposed to both davs being seen as carddavs before. I confirm bug with openSUSE 12.1 and KDE 4.9.5 Updated to KDE 4.10 today. Bug still exists :-( Repository: KDE_Release_410 Name: akonadi Version: 4.10.0-380.1 Arch: x86_64 Vendor: obs://build.opensuse.org/KDE It seems that I found the root of the problem. In davutils.cpp, DavUtils::protocolName() returns a localized string while protocolByName expects untranslated string. It is easy to fix for new installations (just remove i18n() calls, will post a review request tonight) but the real problems is to migrate old data. E.g., the current code writes the localized names to config file. On my computer, I've manually replaced old (localized) strings with the original (CalDav, CardDav) but this didn't help until I removed and recreated the resouce. Looking at the Akonadi logs, it seems that it tried to recreate a collection with the same parentId and name. Hi everyone. This issue is a big deal for me, so I'm willing to pay USD 20.00 for it. This offer is registered on FreedomSponsors (http://www.freedomsponsors.org/core/issue/282/dav-not-working-if-using-swedish-locale). If you solve it (according to the acceptance criteria described there), please register on FreedomSponsors and mark it as resolved there I'll then check it out and gladly pay up! Oh, and if anyone else also wants throw in a few bucks on this, you should check out FreedomSponsors! I'm in with my $25 :-) For the record here is the status of this bug: - Yury (in comment #13) correctly identified the issue and submitted a review at http://git.reviewboard.kde.org/r/110221/ - Despite this great work there was still a bit of work to do. I sent him privately a patch to test on his system and I'm still without news from him. I attach said patch to this report. Of course I let Yury get all the praise and money for this, I'm not commenting now to claim what's not mine; this report just totally slipped out of my mind and I haven't recontacted Yury to get some news. Just please tell if this issue is fixed now. Cheers, Grégory Created attachment 80754 [details]
Fix protocolName translation
I've tried patching kdepim-runtime-4.10.3 (the last stable version in gentoo) and issue seems to be fixed with russian locale. When I add new account CalDav is CalDav in settings, I can edit settings of caldav account and my calendars are synced. I will try the issue with existing account tomorrow. Thank you and especially Yuriy. I'll try to contact him myself to send money. (In reply to comment #16) > For the record here is the status of this bug: > - Yury (in comment #13) correctly identified the issue and submitted a > review at http://git.reviewboard.kde.org/r/110221/ > - Despite this great work there was still a bit of work to do. I sent him > privately a patch to test on his system and I'm still without news from him. > > I attach said patch to this report. Of course I let Yury get all the praise > and money for this, I'm not commenting now to claim what's not mine; this > report just totally slipped out of my mind and I haven't recontacted Yury to > get some news. Just please tell if this issue is fixed now. > > Cheers, > Grégory (In reply to comment #18) > I've tried patching kdepim-runtime-4.10.3 (the last stable version in > gentoo) and issue seems to be fixed with russian locale. When I add new > account CalDav is CalDav in settings, I can edit settings of caldav account > and my calendars are synced. I will try the issue with existing account > tomorrow. Thanks a lot for the feedback. Can you also update this report once you've tested with the existing resources? The tagging for 4.10.5 is tomorrow evening, and I'd like to have this patch included in it as it'll be the last of the 4.10 series. Cheers, Grégory (In reply to comment #19) > (In reply to comment #18) > > I've tried patching kdepim-runtime-4.10.3 (the last stable version in > > gentoo) and issue seems to be fixed with russian locale. When I add new > > account CalDav is CalDav in settings, I can edit settings of caldav account > > and my calendars are synced. I will try the issue with existing account > > tomorrow. > > Thanks a lot for the feedback. Can you also update this report once you've > tested with the existing resources? The tagging for 4.10.5 is tomorrow > evening, and I'd like to have this patch included in it as it'll be the last > of the 4.10 series. > > Cheers, > Grégory Just have tested on existing resources. Seems to be fixed too. Git commit 962e8c301e2c90e9caaeabbddfcb5c0e0eaf03a3 by Grégory Oestreicher. Committed on 26/06/2013 at 16:23. Pushed by goestreicher into branch 'KDE/4.10'. Do not translate the protocols in the configuration Thanks to Yury G. Kudryashov for finding the issue and proposing an initial patch. REVIEW: 110221 M +35 -1 resources/dav/common/davutils.cpp M +12 -1 resources/dav/common/davutils.h M +7 -7 resources/dav/resource/configdialog.cpp M +1 -1 resources/dav/resource/davgroupwareresource.cpp M +22 -0 resources/dav/resource/settings.cpp M +1 -0 resources/dav/resource/settings.h http://commits.kde.org/kdepim-runtime/962e8c301e2c90e9caaeabbddfcb5c0e0eaf03a3 It occured again in 4.13.3 and 4.14.2, the tasks do not show in Korganizer if connected properly via CalDAV. It's occuring in 4 computers. Thunderbird with lightning works. (In reply to Tom Kijas from comment #22) > It occured again in 4.13.3 and 4.14.2, the tasks do not show in Korganizer > if connected properly via CalDAV. > > It's occuring in 4 computers. > > Thunderbird with lightning works. That sounds like a different bug that the one I reported? The bug concerning the locale problem is fixed as far as I know (works here with DAV and OwnCloud). |