Bug 298627

VLC
http://privatepaste.com/e0b912973a

GStreamer
http://privatepaste.com/45263f7f39

I think the VLC one wasn't completely written when I CTRL + C it,
So here's the full version:
http://privatepaste.com/dccae94e34

I'm having the same issue.  Easily reproducible - just load up a playlist and select the repeat playlist option.  The only plugins I am using are mass storage device and lastfm.  I ran the following command to document the leak:  top -b -d 150 -p 11866 > amarok.txt

I then imported the results into a google spreadsheet you can view here:
http://goo.gl/Q4bZw

Memory utilization started out at 7.4% and ended up at 31.9% after approx 48 hours.  The leak is steady and unrelenting.  I ran the same playlist under QMMP during the same period and memory utlization was steady at 2.5% throughout the period.

Gerald, please install Amarok debugging symbols, valgrind and run Amarok from console under valgrind: valgrind --leak-check=full amarok --debug --nofork

If you're able to compile current git version, it would help us even more because some of the memory leaks could have been already resolved. A guide how to do that: 
http://blogs.fsfe.org/myriam/2009/09/compiling-amarok-from-git-locally-full-summary/ (please uninstall distribution Amarok package first)

Reproduce the big memory leak (run Amarok for 2 days), exit it cleanly and then attach valgrind report here; that will help us identify where the memory is lost. Note that Amarok can run considerably slower under valgrind - it is okay, valgrind has to emulate CPU.

Created attachment 71334 [details]
Output of valgrind - part AA (1 of 3)

I don't believe it is necessary to run valgrind for 2 days.  If you look at the google spreadsheet I posted you will see that the increase in memory utilization is steady.  I ran valgrind for approximately 7 hours, hopefully that will show you what you need.  

The leak summary is as follows:
LEAK SUMMARY:
definitely lost: 62,785 bytes in 421 blocks
indirectly lost: 462,826 bytes in 5,620 blocks
possibly lost: 39,984,957 bytes in 186,836 blocks
still reachable: 4,335,737 bytes in 20,146 blocks
suppressed: 0 bytes in 0 blocks

Created attachment 71335 [details]
Output of valgrind - part AB (2 of 3)

Created attachment 71336 [details]
Output of valgrind - part AC (3 of 3)

(In reply to comment #7)
> Created attachment 71336 [details]
> Output of valgrind - part AC (3 of 3)

Thanks for your cooperation, Cerald. We're currently going through your valigrind reports. There ary _many_ things, to it may take us some time to sort it out.

Amarok devs: the leaks are sorted by size, the biggest ones are in part AC.

No problem, let me know if you need additional information.  Thanks!

This bug has been plaguing me for a while (causing my laptop to run out of memory and basically lock up on hard-drive virtual memory access).  Has there been any movement/improvements?  Also, is this bug related to the reason Amarok likes to just stop playing a few seconds into a track that it "fell into" (ie. I didn't immediately tell it to play that song)?  Thanks.

Subscribing the phonon developers, apparently the leak is both in our database handling, engines and the gstreamer backend.

Missing debug symbols for phonon_gstreamer, so the logs are not particularly useful.

FWIW, I recently did a code review for memleaks though I did not find any particularly big leaks. I am however reasonable certain there is a rather grave one somewhere, I just can't seem to find it.
Also a general note: gstreamer passively leaks through its init function, much like QLibrary the memory is meant to free'd on exit by libc.

still leaking, *and stopping playing* between tracks.  not all the time, but the leak is more consistent than the stopping.

Not sure if related, but today I had 2 GB of amarok process, guys are still stuck with reading valgrind's reports or do you think you can fix this?

Could you all please upgrade to Amarok 2.6 and the newer phonon backends? phonon-backend-gstreamer is currently at 4.6.2 and the phonon-backend-vlc at 0.6.0

Dear all, I really need your feedback with Amarok 2.6 and the new phonon-backend-gstreamer 4.6.2, else it doesn't make much sense to keep this report open. Please respond.

Yes, I have phonon-gstreamer-4.7 on kubuntu 12.10.
I start Amarok, krunner shows 40mb
I click next track a bunch of times and the memory goes
increasing...
IMO the valgind reports are really helpful to figure out
what's wrong, there's a lot of definitely lost blocks.

>IMO the valgind reports are really helpful to figure out what's wrong, there's a lot of definitely lost blocks.

except they amount to a total of like 0.3 lost MiB and are not active leaks

well then there might be lots of new Foo(this) that never get deleted as the parent is still alive..

So this is how amarok tend to eat up more and more memory as time pass. I can definitely confirm I have this bug with 2.6 and gstreamer backend 4.6.2. Let me know if you need more debuging symbols.

Except these valgrind outputs are not from Amarok 2.6, please provide a new one. Beforehand, please disable all 3rd-party scripts.

I can't reproduce this here at all, Amarok has been open and playing for over 48 hours now, the total shared memory use is 30 MB.

Amarok 2.6-git, no external scripts, KDE 4.9.2, phonon-backend-vlc 0.6.0

>Amarok 2.6-git, no external scripts, KDE 4.9.2, phonon-backend-vlc 0.6.0

It would only leak with gstreamer btw.

Please, everybody, we need a valgrind output from Amarok 2.6 with the phonon-gstreamer-backend 4.6.2, else there is not much hope of ever fixing this.
Without the requested feedback I will have to close this report.

I have been trying to today but valgrind and/or amarok keeps crashing whenever I try to skip to the next song. Should I post the output nonetheless?

(In reply to comment #24)
> I have been trying to today but valgrind and/or amarok keeps crashing
> whenever I try to skip to the next song. Should I post the output
> nonetheless?

Try only putting tracks of the same type in the playlist, as the gstreamer backend has some issues with switching songs of different types. Of course make sure to use the latest 4.6.2 version of that backend

Created attachment 75656 [details]
valgrind log, scripts & modules disabled

Here is my valgrind output. Amarok 2.6 with all modules & third party scripts disabled. Phonon-gstreamer 4:4.7.0really4.6.2-0ubuntu1. 
I listened to 27 tracks, some of them were skipped by myself to accelerate the process.

Created attachment 75657 [details]
valgrind log, typical scripts & modules enabled

Here is another log, this time I enabled my typical scripts (ultimate lyrics, copy selected tracks, delete current playing file, librivox and radio germany) & modules (local file back-end and lastfm) in Amarok.

Observations: Amarok did choke sometimes some seconds at the beginning of a track or in the middle of it. I believe that is caused by the emulation work valgrind has to do? Never saw that in my regular usage.

Thank you for the feedback.

Git commit d9904f05ce8b8a634f90bc361abe11a6dd18465e by Matěj Laitl.
Committed on 02/01/2013 at 00:11.
Pushed by laitl into branch 'master'.

PlaylistBreadcrumbItemSortButton: fix small memleak

Thanks to Jekyll Wu <adaptee@gmail.com> who found it. The fix is
a simpler version of Jekyll's patch.
REVIEW: 108050

M  +2    -2    src/playlist/PlaylistBreadcrumbItemSortButton.cpp

http://commits.kde.org/amarok/d9904f05ce8b8a634f90bc361abe11a6dd18465e

Hi:
Just upgraded to OpenSuSE 12.3 with Amarok 2.7.0 using Gstreamer 4.6.2.  I still have a memory memory leak of .2M every few seconds.  My playlist is a Radio station url - I don't switch tracks.  Just stream the Radio station all day.  

Here is the Amarok diagnostic display:
Amarok Diagnostics

Amarok Version: 2.7.0
KDE Version: 4.10.3 "release 1"
Qt Version: 4.8.4
Phonon Version: 4.6.0
Phonon Backend: GStreamer (4.6.2)
PulseAudio: Yes

Amarok Scripts:
    Amarok Script Console 1.0 (stopped)
Lyricwiki .2 (stopped)
Free Music Charts 1.6.0 (stopped)
Librivox.org 1.0 (stopped)
Cool Streams 1.0 (stopped)

Amarok Plugins:
    AudioCd Collection (disabled)
DAAP Collection (disabled)
MTP Collection (disabled)
MySQLServer Collection (enabled)
MySQLe Collection (enabled)
Nepomuk Collection (disabled)
UPnP Collection (disabled)
Universal Mass Storage Collection (disabled)
iPod, iPad & iPhone Collection (disabled)
Ampache (disabled)
Jamendo (disabled)
Last.fm (disabled)
MP3 Music Store (disabled)
MP3tunes (disabled)
Magnatune Store (disabled)
Podcast Directory (disabled)
gpodder.net (disabled)

I think I found the root of the issue, but I dunno where it leaks.
The lyrics and wiki information that Amarok retrieves is what
is causing this, if I remove both this issue doesn't happen,
so it might be WebKit leaking or something.
Can you guys try removing those containers and see if it still leaks?

Thanks.

Please, everybody, upgrade your Amarok to 2.7.1 and your phonon-backend-gstreamer to 4.6.3, this is largely fixed by now. I haven't seen a memory leak on track change in ages on current git either.

Upgraded to Amarok 2.7.1 and Phonon backend gstreamer 4.6.3.  I still have memory leak.  Streaming Radio url all day.  Every few seconds memory increases by .3M or so.  e.g. right now memory is 59.4M - started around 44.0M about 5 minutes ago.

I have all the bells and whistles disabled (e.g. no lyrics, wiki, etc.)

Amarok Diagnostics

Amarok Version: 2.7.1
KDE Version: 4.10.3 "release 1"
Qt Version: 4.8.4
Phonon Version: 4.6.0
Phonon Backend: GStreamer (4.6.3)
PulseAudio: Yes

Amarok Scripts:
    Amarok Script Console 1.0 (stopped)
Lyricwiki .2 (stopped)
Free Music Charts 1.6.0 (stopped)
Librivox.org 1.0 (stopped)
Cool Streams 1.0 (stopped)

Amarok Plugins:
    AudioCd Collection (disabled)
DAAP Collection (disabled)
MTP Collection (disabled)
MySQLServer Collection (enabled)
MySQLe Collection (enabled)
Nepomuk Collection (disabled)
UPnP Collection (disabled)
Universal Mass Storage Collection (disabled)
iPod, iPad & iPhone Collection (disabled)
Ampache (disabled)
Jamendo (disabled)
Last.fm (disabled)
MP3 Music Store (disabled)
MP3tunes (disabled)
Magnatune Store (disabled)
Podcast Directory (disabled)
gpodder.net (disabled)

FYI, tried to run Amarok in console using Valgrind (as mentioned in a previous post).  However, after intialization, Amarok crashes when I select the url from the playlist to stream.

I have installed VLC and running with phonon VLC backend now -  Memory is stable.  Abandoning gstreamer backend for now.

Closing correctly.

Here I have to select: use VLC to not be affected by this bug (memory leak on change track), or use Gstream and cannot resume streaming playback (https://bugs.kde.org/show_bug.cgi?id=311953).

(In reply to comment #37)
> Here I have to select: use VLC to not be affected by this bug (memory leak
> on change track), or use Gstream and cannot resume streaming playback
> (https://bugs.kde.org/show_bug.cgi?id=311953).

Sorry, not much we can do about that, the memory leak is in gstreamer, please address that to the right people.