Summary: | Unable to edit newly created events | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libkgapi | Reporter: | Blackpaw <lindsay.mathieson> |
Component: | calendar | Assignee: | Daniel Vrátil <dvratil> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | lindsay.mathieson |
Priority: | NOR | ||
Version: | GIT | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/akonadi-google/062f940c3082d059f1fb6f103cbcce319cff8e7c | Version Fixed In: | 0.3.1 |
Sentry Crash Report: |
Description
Blackpaw
2012-04-21 01:39:45 UTC
Could you please confirm, then when you restart Kontact/Korganizer between steps 2 and 3, the conflict dialog does not appear and everything works as expected? Also, what KDE/Kontact version do you use? Thanks Yes I can confirm that, it worked perfectly when I restarted kontact before doing the edit. kde4-config --version Qt: 4.8.1 KDE Development Platform: 4.8.2 (4.8.2) kde4-config: 1.0 Kontact 4.8.2 Kubuntu 12.04 all updates. Thanks, the issue should now be fixed in the git. Fixed in git master by commit 836690e16e7ed613f1139719649c441530ed3887. http://commits.kde.org/akonadi-google/836690e16e7ed613f1139719649c441530ed3887 Updated trunk and reinstalled, but I'm afraid I'm still getting the problem - where you able to recreate it at your end? Git commit e4c96efe8208dd8740f5c8a9224ce2cce5406be6 by Dan Vrátil. Committed on 23/04/2012 at 23:33. Pushed by dvratil into branch 'master'. Don't update event UID after it's created Untill now we tried to update UID of a newly created event after we received the UID from Google, but KOrganizer didn't cope well with this. This patch removes the IteModifyJob which was updating the UID. We rather keep the KOrganizer-generated UID and we only change it in the payload before serializing it and sending it to Google (for instance when we want to modify the event). This makes KOrganizer happy. FIXED-IN: 0.3.1 M +12 -0 calendar/calendarresource.cpp M +0 -4 calendar/resource_events.cpp M +0 -5 calendar/resource_tasks.cpp http://commits.kde.org/akonadi-google/e4c96efe8208dd8740f5c8a9224ce2cce5406be6 Try now please, it should be OK :) I was able to reproduce it initially, but after the first commit it went away when i tried it. Now I was able to reproduce it again and I'm pretty much sure I found the right cause this time. Please reopen if this issue is still there. Definitely fixed now - brilliant! Very much appreciated, now my desktop, web and phone stay in sync, its immensly useful. Thanks! Git commit 062f940c3082d059f1fb6f103cbcce319cff8e7c by Dan Vrátil. Committed on 23/04/2012 at 23:33. Pushed by dvratil into branch '0.3'. Don't update event UID after it's created Untill now we tried to update UID of a newly created event after we received the UID from Google, but KOrganizer didn't cope well with this. This patch removes the IteModifyJob which was updating the UID. We rather keep the KOrganizer-generated UID and we only change it in the payload before serializing it and sending it to Google (for instance when we want to modify the event). This makes KOrganizer happy. FIXED-IN: 0.3.1 M +12 -0 calendar/calendarresource.cpp M +0 -4 calendar/resource_events.cpp M +0 -5 calendar/resource_tasks.cpp http://commits.kde.org/akonadi-google/062f940c3082d059f1fb6f103cbcce319cff8e7c |