Bug 298178

Summary:	Move photos dialog default button is Cancel, not Ok
Product:	[Applications] digikam	Reporter:	Will Stephenson <wstephenson>
Component:	Usability-Ergonomy	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, smit.meh
Priority:	NOR
Version:	2.5.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:	2.6.0
Sentry Crash Report:
Attachments:	screenshot

Description Will Stephenson 2012-04-15 12:12:03 UTC

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/536.4 (KHTML, like Gecko) Chrome/19.0.1074.0 Safari/536.4 SUSE/19.0.1074.0
Build Identifier: 

The "Move photos dialog" default button is Cancel, not Ok.  Compare with the default button on the Delete Album or Move photo to Wastebin dialogs - here it is Cancel.  This inconsistency is dangerous - I just hit Enter in Move Photos, which cancelled the move, then deleted the album thinking they had been moved, using Enter again.

Reproducible: Always

Actual Results:  
Inconsistent default buttons lead to hard to learn and risky UI.

Expected Results:  
Same default button on all similar dialogs

Comment 1 Will Stephenson 2012-04-15 12:14:55 UTC

I just noticed that the inconsistency is shown best if you try to move photos to the album that is selected by default in the Move Photos dialog, for example, the album moved to the last time the dialog was used.  Then Cancel is focused.

On the other hand, if you have to select an album in the treeview with the cursor keys, pressing Enter with the treeview focussed Ok's the dialog.

Comment 2 Smit Mehta 2012-04-15 14:15:32 UTC

Hi

Gilles, what do you suggest? Should I change it?

Smit

Comment 3 caulier.gilles 2012-04-15 15:41:51 UTC

I'm not sure to understand the problem. Someone can take some screenshot of GUI in action please ?

Gilles Caulier

Comment 4 Smit Mehta 2012-04-15 15:44:16 UTC

Created attachment 70397 [details]
screenshot

Steps to reproduce ->
(i) right click on any image
(ii) click on 'move to album...'

the default button is 'cancel' here, while the user wants it to be 'okay' because of uniformity issues.

smit

Comment 5 caulier.gilles 2012-04-15 15:51:29 UTC

Yes, it's fine to patch dialog...

Gilles

Comment 6 Smit Mehta 2012-04-15 17:38:20 UTC

Git commit 3d55be27b7893945cc6f158cf0613e8c8cda62c0 by smit mehta.
Committed on 15/04/2012 at 19:37.
Pushed by smitmehta into branch 'master'.

Default button 'Ok' for maintaining uniformity

M  +2    -1    NEWS
M  +0    -1    digikam/album/albumselectdialog.cpp

http://commits.kde.org/digikam/3d55be27b7893945cc6f158cf0613e8c8cda62c0