Bug 297981

Summary:	Rendering of unfilled line markers is broken
Product:	[Applications] calligracommon	Reporter:	Friedrich W. H. Kossebau <kossebau>
Component:	flake	Assignee:	Calligra Bugs <calligra-bugs-null>
Status:	CONFIRMED ---
Severity:	normal
Priority:	NOR
Version:	2.4-snapshots
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	ODG file with lines with markers with the broken rendering Patch to add the UML line ends as in LO 3.5 to Calligra Comparison of rendering in Calligra current master (left) to LO 3.5 feature picture (right)

Description Friedrich W. H. Kossebau 2012-04-12 16:39:05 UTC

User-Agent:       Mozilla/5.0 (X11; Linux) KHTML/4.8.2 (like Gecko) Konqueror/4.8 SUSE
Build Identifier: 

Adding the UML line ends* to markers.xml shows that markers with holes in it are not rendered correctly. A few weeks ago I think I saw them rendered correctly, but so far I could not find a commit which might have affected this since then. Both with 2.4 and master.

* Those are found in LibreOffice, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=7661f0943d6286b7e7075c5f2e172f23d53ea47d

Reproducible: Always

Steps to Reproduce:
1. Add any of the unfilled markers from LO 3.5 standard.soe to Calligra's marker.xml (besides the unfilled circle, that works)
2. Start Karbon
3. Create a line
4. Set line end to the added marker (and see already in the selector the broken rendering)
Actual Results:  
There is no hole in the marker, instead the "hole" defining shape is additionally rendered filled with a small offset to the outer shape of the marker.

Expected Results:  
The markers are rendered like to be seen in LO (3.5).

Comment 1 Friedrich W. H. Kossebau 2012-04-12 16:40:24 UTC

Created attachment 70346 [details]
ODG file with lines with markers with the broken rendering

Comment 2 Friedrich W. H. Kossebau 2012-04-12 16:43:43 UTC

Created attachment 70347 [details]
Patch to add the UML line ends as in LO 3.5 to Calligra

Comment 3 Friedrich W. H. Kossebau 2012-04-13 14:12:59 UTC

Created attachment 70364 [details]
Comparison of rendering in Calligra current master (left) to LO 3.5 feature picture (right)

Comment 4 Camilla Boemann 2012-06-09 17:15:49 UTC

Git commit 501f4d55d0828b7a9ca1c62500454358feb4a0b1 by C. Boemann.
Committed on 09/06/2012 at 19:10.
Pushed by boemann into branch 'master'.

Fix that in svg:d if a z command is followed by m or M then the current coords
shouldn't be reset.

M  +10   -2    libs/flake/KoPathShapeLoader.cpp

http://commits.kde.org/calligra/501f4d55d0828b7a9ca1c62500454358feb4a0b1

Comment 5 Yue Liu 2012-06-13 09:51:35 UTC

Git commit 0277f5a9d95a5eac78ff69081af1aee81c8a265d by Yue Liu, on behalf of C. Boemann.
Committed on 09/06/2012 at 19:10.
Pushed by liu into branch 'connection-interaction-yue'.

Fix that in svg:d if a z command is followed by m or M then the current coords
shouldn't be reset.

M  +10   -2    libs/flake/KoPathShapeLoader.cpp

http://commits.kde.org/calligra/0277f5a9d95a5eac78ff69081af1aee81c8a265d

Comment 6 Justin Zobel 2021-03-09 01:22:46 UTC

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.