| Summary: | Users should be prompted for a new password when entering a new one | ||
|---|---|---|---|
| Product: | [Applications] ark | Reporter: | Raphael Kubo da Costa <rakuco> |
| Component: | general | Assignee: | Raphael Kubo da Costa <rakuco> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kedgedev |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/ark/8492cc21b5a45eb047109b754906a551de061065 | Version Fixed In: | 15.07.80 |
| Sentry Crash Report: | |||
| Attachments: | Romain's patch | ||
Git commit 8492cc21b5a45eb047109b754906a551de061065 by Ragnar Thomsen. Committed on 30/05/2015 at 17:03. Pushed by rthomsen into branch 'frameworks'. Fix password never being asked again after a wrong one has been entered Previously, if the user entered a wrong password for a password- protected archive, Ark would remember that a wrong password had been entered and had to be closed down to allow entering the password again. This commit fixes this issue by presenting the "Enter password" dialog again when the user attempts some action that requires access to the password-protected files. FIXED-IN: 15.07.80 REVIEW: 123358 M +10 -2 kerfuffle/cliinterface.cpp M +1 -1 part/part.cpp http://commits.kde.org/ark/8492cc21b5a45eb047109b754906a551de061065 |
Created attachment 70280 [details] Romain's patch Romain Jarosz emailed me a few months ago with a patch to make Ark query users for the archive password when it is entered incorrectly. The current behavior is quite annoying: if a wrong password is entered, it can never be reset throughout Ark's lifetime. Plus, the dialog showing that a wrong password has been entered has different messages (and icons) depending on whether the incorrect password has been entered when listing a header-compressed archive or during extraction. Romain's patch does solve the problem with the password never being asked again, but the other deficiencies pointed out above should be fixed as well. Bonus points if this is unit tested :-)