Bug 297396

Summary: default sorting for priority is descending
Product: [Applications] korganizer Reporter: suse
Component: todoviewAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: bo.gran
Priority: NOR    
Version First Reported In: 4.8.x   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 4.8.5
Sentry Crash Report:
Attachments: bad priority sorting example

Description suse 2012-04-03 15:28:28 UTC
Created attachment 70118 [details]
bad priority sorting example

I have some todo entries with due date and some without.
The sorting is with "due date".

The problem is, that the sorting of all "non due dates" is made with *descending* priority.
That means, the most important ("1") todo is at the bottom of the list (right before the finished tasks)

IMHO, the most important todo should be at the top of the list (right behind of the tasks with due date)
Comment 1 bo.gran 2012-05-11 10:12:32 UTC
This is also a general problem concerning the sort issue. E.g if you explicitly sort on "Due Date" (or whatever else) and there are entries with the same values, the _second_ implicit sort criteria should, IMHO, be priority by ascending. This gives
Prio | Due Date v
  1   | 2012-03-03
  3   | 2012-04-04
  4   | 2012-04-04


instead of
Prio | Due Date v
  1   | 2012-03-03
  4   | 2012-04-04
  3   | 2012-04-04
Comment 2 Allen Winter 2012-06-27 16:11:26 UTC
Git commit edb192656e0280670fda387c15436424dd2d3bcd by Allen Winter.
Committed on 27/06/2012 at 18:04.
Pushed by winterz into branch 'master'.

fix the sorting order of priorities when used as the fallback sort
field for to-dos without a due date.
MERGE: 4.8,4.9
FIXED-IN: 4.8.5

M  +1    -1    korganizer/views/todoview/kotodoviewsortfilterproxymodel.cpp

http://commits.kde.org/kdepim/edb192656e0280670fda387c15436424dd2d3bcd
Comment 3 Allen Winter 2012-06-27 16:11:58 UTC
Git commit 7e9a7a07fb2dcffe18120db7c14831b90e677d76 by Allen Winter.
Committed on 27/06/2012 at 18:04.
Pushed by winterz into branch 'KDE/4.9'.

fix the sorting order of priorities when used as the fallback sort
field for to-dos without a due date.
MERGE: 4.8,4.9
FIXED-IN: 4.8.5
(cherry picked from commit edb192656e0280670fda387c15436424dd2d3bcd)

M  +1    -1    korganizer/views/todoview/kotodoviewsortfilterproxymodel.cpp

http://commits.kde.org/kdepim/7e9a7a07fb2dcffe18120db7c14831b90e677d76
Comment 4 Allen Winter 2012-06-27 16:12:13 UTC
Git commit 73a713bcdb3b87df19f69a6ec852086321aab499 by Allen Winter.
Committed on 27/06/2012 at 18:04.
Pushed by winterz into branch 'KDE/4.8'.

fix the sorting order of priorities when used as the fallback sort
field for to-dos without a due date.
MERGE: 4.8,4.9
FIXED-IN: 4.8.5
(cherry picked from commit edb192656e0280670fda387c15436424dd2d3bcd)

M  +1    -1    korganizer/views/todoview/kotodoviewsortfilterproxymodel.cpp

http://commits.kde.org/kdepim/73a713bcdb3b87df19f69a6ec852086321aab499