| Summary: | Like from SLC doesnt show the star rating | ||
|---|---|---|---|
| Product: | [Unmaintained] Active | Reporter: | Fania Bremmer <fania.bremmer> |
| Component: | Share Like Connect | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | active, lamarque |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | unscheduled | ||
| Platform: | Meego/Harmattan | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Fania Bremmer
2012-03-28 07:14:15 UTC
Git commit 4da77d6ff103cb6651ad817f4829fb354929a6f9 by Marco Martin. Committed on 28/03/2012 at 10:33. Pushed by mart into branch 'master'. revert f48becacac12f337579526c6dfddfa253206ce4f it did break star rating in SLC M +2 -17 dataengines/metadata/metadataengine.cpp M +0 -1 dataengines/metadata/metadataengine.h http://commits.kde.org/plasma-mobile/4da77d6ff103cb6651ad817f4829fb354929a6f9 The feedback works now but the number of highlighted stars is lost once you select another "likeably" item. For example, you set the number of starts of an image, then select another image, when you go back to the first image the number of stars is zero. I tested 2012-03-31-09-53-basyskom-plasma-active-devel-meego-usb-live.iso, which is supposed to include the commit above. I can confirm the problem with the lost stars, reported by lamarque tested on 2012-04-04-11-10-basyskom-plasma-active-testing-meego-usb-live.iso Git commit 211981d6ff8c5ed7a37dbc63595b443909a8a6a9 by Marco Martin. Committed on 04/04/2012 at 16:14. Pushed by mart into branch 'master'. drop the old private datamanegement usage now is used internally in Nepomuk::Resource D +0 -466 dataengine/providers/rating/datamanagement.h M +1 -3 dataengine/providers/rating/ratingProvider.cpp http://commits.kde.org/share-like-connect/211981d6ff8c5ed7a37dbc63595b443909a8a6a9 (In reply to comment #2) > The feedback works now but the number of highlighted stars is lost once you > select another "likeably" item. For example, you set the number of starts of > an image, then select another image, when you go back to the first image the > number of stars is zero. If I reboot the device then the stars appears correctly. I think the containment is not updating the items' properties from nepomuk when they are changed. I noticed this problem when debugging the problem with resources of private activities disappearing after reboot. This seems to be a problem with nepomuk's cache. Metadata dataengine successfully stores the new rating value, but MetadataEngine::prepareSource when it instantiate a Nepomuk::Resource object and calls "container->setResource(resource)" it reads the old value from the Nepomuk::Resource object instead of the new one. I tried adding Nepomuk::ResourceManager::clearCache() before instantiating the object but it did not work. this seems related to all the changes have been in resource caching (that caused the slowdown regressions last weeks too) did you try with the last commit above in slc? using setpropoerty instead of the old semi private api seems to fix things here (will port the rest using that api too) i think in that case Resource notifies itself internally that a property has changed, marking the cache as dirty The commit above fixed the problem. Fixed in 2012-04-23-16-57-basyskom-plasma-active-testing-meego-usb-live.iso |