Bug 296883

The share total balance is increased by the number of shares bought, but the amount paid is zero.

Created attachment 75767 [details]
Patch to use brokerage account as default for buy/sell

Patch checked out on QIF file imported from Moneydance.

I ran into the same problem on the current GIT version of KMM (4.6.90), openSUSE 12.2.

I confirm this in 4.6.3 with OFX, even if the brokerage account name is set to the default of the investment account name followed by ' (brokerage)'.  However, editing the imported transaction and specifying the brokerage account does fix the transaction - leaving a correctly incremented number of shares and the correct purchase price deducted from the brokerage account.  Interestingly, when I hover over the transaction in the ledger, the error is missing category, which might technically be correct, but that terminology seems to apply to a normal transaction not to an investment transaction.

While this issue is still present, there does seem to have been an improvement.  (I think the change is present in 4.7, but I will have to reconfirm.)  Now, the error shows up on import, but as soon as I open the transaction for editing, the brokerage account is filled in correctly.  However, if I click "Accept" (before editing) then the yellow background (showing imported) goes away, but the status does not change to "cleared" and if I then edit, although the brokerage account is filled in, the "Enter" button is not available until I change the status.  I will try to create a test file, but as I do most of my investment imports with OFX direct, I'll have to try to capture one of those transactions in a file.

When I create a new .kmy file to test, this works fine, indicating the brokerage account on import, no intervention required.  I'm still seeing the issue with my own file, but it may be related to how I created the investmenta and brokerage accounts (long ago).  I did not initially accept the default, and used a non-standard name for the brokerage account, later renaming it to the standard format.  However, creating a new file and renaming the brokerage account like this also works correctly.  Since it will not be reasonably possible to pare down my own file to submit, I'm going to say this is resolved, unless anyone else is seeing the problem.  (I confirm with git master, but I don't have 4.7 installed.)

It would be nice if you could find the difference between the new file and your file. If you have that we can conclude if there is a bug or not, did you try creating an anonymous file?

The anonymous file is about 6MB.  Should I just attach it, or try to delete unnecessary accounts and stuff?  Also note, the anonymous file loses the proper matching name of the brokerage account, although it does show this problem with or without renaming the brokerage account.

Created attachment 89563 [details]
OFX file which exhibits the problem

Created attachment 89564 [details]
Anonymous .kmy file which exhibits the problem

I was able to get the file down to ~200KB.  If you import the ofx file from comment 9 into the anonymous kmy file from comment 10, importing into account A000255, both imported transactions show the problem.  If you rename account A000256 to "A000255 (Brokerage)" and then import, the problem still happens, but as soon as you edit one of the imported transactions, the brokerage account is filled in.  Also note the newly discovered issue that in the two situations (renaming the brokerage account or not) the imported transactions are different, but that's a bug for a different report.

I'll take a look at it sometime next week, thanks for creating the necessary test data.

OK, reproduced the problem looking at what is causing this.

I found what's causing the pre-fill behavior it's Activity::preloadAssetAccount(). I assume we would need the same logic in the importer but I need to think about this after a good night's sleep.

This refers both to OFX and QIF (in 2012).  Is there still aproblem with QIF import?  In what way?

I used to have problems with QIF when importing a new investment, which also, and unwanted by me, automatically created the (Brokerage) account even if the transactions included an existing check account to use.  I much later incorporated a fix which created the Brokerage account later, and only of needed.

It may be that the QIF issue no longer exists, or then....  Has anyone noticed?

I don't know if the patch Cristian created would even be applicable to 5.x, but the problem seems to be still present, although perhaps slightly changed.  Importing OFX now prompts me for the brokerage account, even when it does use the default name.  I will try with the attached sample files, but I'd love to know if I'm the only one seeing this issue.  (Happens with OFX file or direct connect.)

This is still present in git master.  If I import ofx, even if the brokerage account has the default name, I am prompted for the name of the brokerage account every import.  Even worse, with the recent change to not pop up a status for every account, if you Update All Accounts, you don't know which account is being prompted for, making it useless to to that with multiple investment accounts.

Created attachment 114609 [details]
OFX -> KMyMoney transaction field mapping for specific investment transaction

Taking the attached OFX file and a manually entered reinvestment transaction I think one could implement the attached conversion. I have no idea if this makes sense and supports the necessary reporting requirements as it is simply based on current existing logic. Comments welcome.

Created attachment 118592 [details]
attachment-17424-0.html

 I recently downloaded Kmymoney 5.0 for windows 8.1. I had an unpleasant
surprise, because using OFX to download the bank statement is not working
for banks here in Brazil - English version - there is no Portuguese version
- because in previous versions this always worked well. Now, even wanting
to go back to previous versions, they do not work as they did before. I've
used more than one browser to see if the problem would resolve itself, but
it was in vain.

Em seg, 16 de jul de 2018 às 19:31, Jack <bugzilla_noreply@kde.org>
escreveu:

> https://bugs.kde.org/show_bug.cgi?id=296883
>
> Jack <ostroffjh@users.sourceforge.net> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|
> |ostroffjh@users.sourceforge
>                    |                            |.net
>
> --- Comment #16 from Jack <ostroffjh@users.sourceforge.net> ---
> I don't know if the patch Cristian created would even be applicable to
> 5.x, but
> the problem seems to be still present, although perhaps slightly changed.
> Importing OFX now prompts me for the brokerage account, even when it does
> use
> the default name.  I will try with the attached sample files, but I'd love
> to
> know if I'm the only one seeing this issue.  (Happens with OFX file or
> direct
> connect.)
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

Ciao-please provide some more information.
- Exactly which version are you using and from where did you download it.
- What do you mena by "not working?"  At what point in the process does it fail?
- Have you tried both direct connect and importing a manually downloaded file?
- Are you getting any error message?
Also, note that this bug is about the import not properly assigning the brokerage account for an investment transaction which needs one, it is not about ofx import failing.

(In reply to Jack from comment #17)
Comment #17 still applies:  If I import ofx, even if the brokerage account has the default name, I am prompted for the name of the brokerage account every import.  And, without a status pop-up for every account, if you Update All Accounts, you don't know which account is being prompted for, making it useless to do that with multiple investment accounts.

Not sure if this needs to be renamed, or split into more than one bug.

I don't know if this was explicitly addressed, or if it got fixed as part of some other commit, but I no longer seem to have this problem.  There are rare cases where I am still prompted for the name of the account being imported, but it is not related to investment/brokerage accounts.  If nobody else reports still seeing this issue, I'll close this as WORKSFORME in a week or two.

Jack, I believe it could have been fixed by https://invent.kde.org/office/kmymoney/-/commit/dcdd81c2cbc1f1df94c34fb5e5944bb24be8a98b

That looks right.  I'll close as fixed, using that commit, and 5.1.1 as version.