Bug 296367

Summary:	imageviewer: resizing with pinch&zoom gesture vs buttons
Product:	[Plasma] Active	Reporter:	Fania Bremmer <fania.bremmer>
Component:	Applications	Assignee:	active
Status:	RESOLVED UNMAINTAINED
Severity:	minor	CC:	notmart, sebas, thomas.pfeiffer
Priority:	NOR
Version:	PA 2
Target Milestone:	unscheduled
Platform:	Meego/Harmattan
OS:	Linux
Latest Commit:		Version Fixed In:

Description Fania Bremmer 2012-03-19 15:12:30 UTC

on 2012-03-19-10-07-basyskom-plasma-active-devel-meego-usb-live.iso 

- open an image in the image viewer
- manipulate the size of the image with pinch & Zoom; do the same thing with the buttons.
-> why do we offer a duplicate function with the zoom-in and zoom-out buttons? Its more convenient to use the pinch&zoom gesture, the same gesture is used in the activeBrowser, so its consistent for zooming in and out. In the Browser there is no duplicate button to do so, why here?

Comment 1 Sebastian Kügler 2012-03-20 09:37:57 UTC

Not all devices / software stacks have working multitouch. In the browser, zoom is also provided through doubletaps on the page, that's why there are no buttons for it.

Once we can require multitouch working for all devices, I think the +- buttons can go away, as pinch is a common gesture.

Comment 2 Thomas Pfeiffer 2012-03-20 10:05:56 UTC

(In reply to comment #1)
> Not all devices / software stacks have working multitouch. In the browser,
> zoom is also provided through doubletaps on the page, that's why there are
> no buttons for it.
> 
> Once we can require multitouch working for all devices, I think the +-
> buttons can go away, as pinch is a common gesture.

Could we introduce a way to make it easy for image creators to enable or disable the buttons for their respective device-specific image? I know that theoretically not every image is device-specific, but given our experiences with PA images so far, it seems to me that most images have to be created with a specific device in mind anyway, since even those with an x86 architecture are too different for a "one size fits all" approach anyway.
This should not be a user option because the buttons are required for non-multitouch devices but pretty useless for multitouch devices.

Comment 3 Marco Martin 2012-04-16 08:40:10 UTC

Git commit 266e7a0b70d325af3bb6da1a45bf2e1dd537a2d4 by Marco Martin.
Committed on 16/04/2012 at 10:37.
Pushed by mart into branch 'master'.

add hasMultiTouch in the capabilities engine

hide zoom buttons in the viewer if hasMultiTouch

M  +8    -0    applications/filebrowser/imageviewerpart/contents/ui/ViewerPage.qml
M  +2    -0    dataengines/devicecapabilities/capabilitiesengine.cpp

http://commits.kde.org/plasma-mobile/266e7a0b70d325af3bb6da1a45bf2e1dd537a2d4

Comment 4 Thomas Pfeiffer 2012-12-06 22:07:00 UTC

Currently on Mer on Wetab, the buttons are still displayed. Does that mean that hasMultiTouch is not set here or that there is a bug in the code?