Summary: | Different binary name for KWin Active | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Martin Flöser <mgraesslin> |
Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | ach, jr |
Priority: | NOR | Flags: | mgraesslin:
ReviewRequest+
|
Version: | git master | ||
Target Milestone: | 4.9 | ||
Platform: | unspecified | ||
OS: | Linux | ||
URL: | https://bugs.launchpad.net/ubuntu/+source/kubuntu-active-meta/+bug/956186 | ||
Latest Commit: | http://commits.kde.org/kde-workspace/df3fc9a04d47ca0f5b395257382080bc8ffd6b52 | Version Fixed In: | 4.9.0 |
Description
Martin Flöser
2012-03-15 17:01:31 UTC
current bug in kubuntu is https://bugs.launchpad.net/ubuntu/+source/kubuntu-active-meta/+bug/956186 kwin_active: #!/bin/sh kwin --config kwinactiverc $* we only have to ensure we don't open the config explicitly anywhere, also i've no idea how this impacts and how to control the kcms FWIW: to support positional args with spaces it should be exec kwin -config kwinactiverc "$@" $ listargs "one ..." two ... 'three and a bit more' args are: <one ...> <two> <...> <three and a bit more> $ bash -c 'listargs $*' prg "one ..." two ... 'three and a bit more' args are: <one> <...> <two> <...> <three> <and> <a> <bit> <more> $ bash -c 'listargs "$@"' prg "one ..." two ... 'three and a bit more' args are: <one ...> <two> <...> <three and a bit more> Review Request created: https://git.reviewboard.kde.org/r/104299/ @Jonathan: I could not find you in the CC list, that's why you are not added. It would be nice if Kubuntu devs could test the change if anything is still conflicting. Git commit df3fc9a04d47ca0f5b395257382080bc8ffd6b52 by Martin Gräßlin. Committed on 16/03/2012 at 08:37. Pushed by graesslin into branch 'master'. Add CMake variable to rename kwin binaries A CMake variable is used to specify the name of the binary. By default this is "kwin" but building for PA changes the name to "kwinactive". The variable adjusts all names, e.g. kwinnvidiahack becomes kwinactivenvidiahack. The remaining usage of kwinrc in core and libs is replaced by a cmakedefine for the configuration name and all data installations are moved to the defined name. Dynamic loading for scripts & co is adjusted for loading based on defined name. This change allows the side-by-side installation of both kwin for desktop and kwin for Plasma Desktop without the known issues like conflicts in config files or missing build options if kwin desktop is used for Plasma Active. Likewise the KCMs are not adjusted as they are not intended to be used for kwinactive. REVIEW: 104299 FIXED-IN: 4.9.0 CCMAIL: active@kde.org M +11 -2 kwin/CMakeLists.txt M +2 -0 kwin/config-kwin.h.cmake M +2 -1 kwin/effects.cpp M +2 -0 kwin/effects/CMakeLists.txt M +2 -2 kwin/effects/fade/CMakeLists.txt M +2 -2 kwin/effects/fadedesktop/CMakeLists.txt M +3 -0 kwin/libkwineffects/CMakeLists.txt M +2 -1 kwin/libkwineffects/kwineffects.cpp M +6 -6 kwin/main.cpp M +1 -1 kwin/scripting/scripting.cpp M +3 -3 kwin/scripts/CMakeLists.txt M +3 -3 kwin/tabbox/declarative.cpp M +20 -20 kwin/tabbox/qml/CMakeLists.txt http://commits.kde.org/kde-workspace/df3fc9a04d47ca0f5b395257382080bc8ffd6b52 |