Bug 296057

Summary: gwenview does not build with latest libkipi master (with EffectsPlugin removed)
Product: [Applications] gwenview Reporter: Jozef Šiška <yoyo>
Component: generalAssignee: Gwenview Bugs <gwenview-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, cfeck, imaging-bugs-null
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: complete (gentoo) build log

Description Jozef Šiška 2012-03-15 11:40:25 UTC 
User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.54 Safari/535.19
Build Identifier: 

gwenview from git/master doesn't compile with libkipi from git/master because EffectsPlugin category was removed (commit 7921aef)

Reproducible: Always

Steps to Reproduce:
1. compile/install libkipi from git
2. compile gwenview
3.
Actual Results:  
compile  fails with:
/mnt/huge/tmp/portage/kde-base/gwenview-9999/work/gwenview-9999/app/kipiinterface.cpp: In member function ‘void Gwenview::KIPIInterface::loadPlugins()’:
/mnt/huge/tmp/portage/kde-base/gwenview-9999/work/gwenview-9999/app/kipiinterface.cpp:247:21: error: ‘EffectsPlugin’ is not a member of ‘KIPI’
Comment 1 Jozef Šiška 2012-03-15 11:44:13 UTC 
Created attachment 69638 [details]
complete (gentoo) build log
Comment 2 Christoph Feck 2012-03-15 21:49:26 UTC 
The enum for "EffectsPlugin" has been removed, but I am not sure if this was intentional.

Commit 7921aefdd37e145dcdcccf3b7d82f3072c0d9f62 looks like (an incorrect) revert of 8a1c90a233935f4afa1091b53ead41031840bd64

Gilles, can you confirm that the enum value should have been removed?
Comment 3 caulier.gilles 2012-03-15 21:53:31 UTC 
Yes there is not EffectPlugins since a long time into kipi-plugins. All have been converted as ToolPlugins.

it's the same for CollectionPlugins, but for the moment, i don't touch of this type.

As i don't find a way to mark a specific enum value, i removed it.

You can drop warp code around EffectPlugins in gwenview...

Note, i proposed a GSoC 2012 project to port all kipi-plugins to KDE XML GUI API. But we will talk about later if project is retained.

Gilles Caulier
Comment 4 Christoph Feck 2012-03-15 22:10:09 UTC 
Thanks for the update.

Fixed by Allen Winter.

See http://commits.kde.org/gwenview/cf50c4da180f849f563218635ff2bffb98a84de4