Bug 295916

Summary: Approve SSH Contact Channels
Product: [Unmaintained] telepathy Reporter: Daniele E. Domenichelli <ddomenichelli>
Component: approverAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: adrian, kde, mail
Priority: NOR    
Version: git-latest   
Target Milestone: 0.5-next   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-approver/fbccd5e8b96eccebb67669da12dec44326304299 Version Fixed In:
Sentry Crash Report:

Description Daniele E. Domenichelli 2012-03-13 12:43:18 UTC 
"SSH Contact" Channels are not approved. You still require the credentials to login but I think we should let the user approve the connection or at least display a notification that someone connected to your computer
Comment 1 David Edmundson 2012-03-19 13:28:03 UTC 
Assigning to me, started last night. Will make it generic for all Streams.

(though as far as I can tell, the only way I can see what type of stream it is is a string called "service").
Comment 2 George Kiagiadakis 2012-03-19 13:35:11 UTC 
(In reply to comment #1)
> (though as far as I can tell, the only way I can see what type of stream it
> is is a string called "service").

And that is why we need .desktop files for each tube app.
Comment 3 David Edmundson 2012-03-19 13:37:37 UTC 
Agreed. I won't make something good, but we'll at least have it block incoming tubes, right now it's a bit scary that I can just reach anyone's computer without notification.

We're gonna have to be a bit careful marketing tubes. I've already seen someone get "stressed out" about them on someone's blog (I think George's).
Comment 4 David Edmundson 2012-05-17 10:48:56 UTC 
This is done, just waiting merge after freeze ends. Poke d_ed.
Comment 5 David Edmundson 2012-06-25 21:36:20 UTC 
Git commit fbccd5e8b96eccebb67669da12dec44326304299 by David Edmundson.
Committed on 02/04/2012 at 03:00.
Pushed by davidedmundson into branch 'master'.

Add a basic approver for streamtubes.

Currently this only handles x-ssh-contact, and it's hardcoded to support just the one tube.
It shows an icon whilst the session is in progress, so the user can cancel it at any time.

REVIEW: 104465

M  +1    -0    src/CMakeLists.txt
M  +1    -0    src/approverdaemon.cpp
M  +7    -0    src/channelapprover.cpp
M  +5    -0    src/ktpapprovermodule.cpp
A  +121  -0    src/streamtubechannelapprover.cpp     [License: LGPL (v2.1+)]
A  +45   -0    src/streamtubechannelapprover.h     [License: LGPL (v2.1+)]

http://commits.kde.org/telepathy-approver/fbccd5e8b96eccebb67669da12dec44326304299
Comment 6 Adrián Chaves (Gallaecio) 2012-08-26 17:59:49 UTC 
I think this bug can be closed now.
Comment 7 George Kiagiadakis 2012-08-26 20:37:40 UTC 
It *is* already closed, like other bugs that you commented on similarly...