Bug 295891

Summary: Wrong date for the "Ascension" day in Indonesian holiday file, (possibly holiday in other country too)
Product: [Applications] kdepimlibs Reporter: Ronggo Radityo <radityo3000>
Component: kholidaysAssignee: John Layt <jlayt>
Status: RESOLVED FIXED    
Severity: minor CC: kdepim-bugs
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 4.10
Attachments: Indonesian KHoliday Files (fixed)
Indonesian KHoliday Files english version (fixed)

Description Ronggo Radityo 2012-03-13 03:17:15 UTC
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build Identifier: 

Quote from http://en.wikipedia.org/wiki/Ascension_of_Jesus:
"The Feast of the Ascension, celebrated on the 40th day of Easter (always a Thursday), ...."

There are calculation differences between eastern and western churches (http://en.wikipedia.org/wiki/Feast_of_the_Ascension) but for Indonesia, I wrote it in holiday_id_en-us as:
: Kenaikan Yesus Kristus
"Ascension Day"                          weekend on easter plus 40 days

That resulted in the holiday falls on the 41st day of easter (Friday May 18, 2012). Officialy, in Indonesia, this year's Ascension day is Thursday, May 17, 2012.  When I check other holiday files (grep -lir ascension /usr/share/apps/libkholidays/plan2/), there are three version of the holiday.
Those who use "easter plus 39 days" (it falls on Thursday. I assumed this is the correct date)
- holiday_at_de
- holiday_wf_fr
- holiday_re_fr
- holiday_ch_fr
- holiday_nc_fr
- holiday_yt_fr
- holiday_gt_es
- holiday_gt_fr
- holiday_gp_fr
- holiday_lu_fr

Those who use "easter plus 42 days" (It falls on Sunday, which according to http://en.wikipedia.org/wiki/Feast_of_the_Ascension#Sunday_observance is correct)
- holiday_it_it
- holiday_sm_it
- holiday_nz_en-gb

Those who use "easter plus 40 days":
- holiday_us_en-us
- holiday_pt_pt
- holiday_na_en-gb
- holiday_id_id
- holiday_id_en-us

Now I cannot be sure about other country's holiday, but for Indonesia the correct holiday should use "weekend on easter plus 39 days". I'll attach the correct Indonesian kholiday files. 


Reproducible: Always

Steps to Reproduce:
1. Open calendar (with Indonesian holiday activated)
2. Search for Ascension Day 

Actual Results:  
It falls on Friday

Expected Results:  
It should be Thursday
Comment 1 Ronggo Radityo 2012-03-13 03:20:07 UTC
Created attachment 69561 [details]
Indonesian KHoliday Files (fixed)

Changed:
- change Ascension day from "weekend on easter plus 40 days" to "weekend on easter plus 39 days"
Comment 2 Ronggo Radityo 2012-03-13 03:22:09 UTC
Created attachment 69562 [details]
Indonesian KHoliday Files english version (fixed)

Changed:
- Change Ascension day from "weekend on easter plus 40 days" to "weekend on easter plus 39 days"
Comment 3 Christophe Marin 2013-01-19 00:48:57 UTC
Git commit 8eac36cdb125ed05b6503e8baaa76c18706a42f4 by Christophe Giboudeaux.
Committed on 19/01/2013 at 01:47.
Pushed by cgiboudeaux into branch 'KDE/4.10'.

Fix the 'Ascension Day' date for Indonesia.

Patch provided by Ronggo Radityo. Thank you
FIXED-IN: 4.10

M  +2    -2    kholidays/holidays/plan2/holiday_id_en-us
M  +2    -2    kholidays/holidays/plan2/holiday_id_id

http://commits.kde.org/kdepimlibs/8eac36cdb125ed05b6503e8baaa76c18706a42f4