Bug 295836

Summary:	Generate a list of all handlers at runtime
Product:	[Frameworks and Libraries] telepathy	Reporter:	Daniele E. Domenichelli <ddomenichelli>
Component:	common-internals	Assignee:	George Kiagiadakis <mail>
Status:	CONFIRMED ---
Severity:	task	CC:	kde, mklapetek
Priority:	LO	Flags:	ddomenichelli: ReviewRequest+
Version:	git-latest
Target Milestone:	0.6-next
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Daniele E. Domenichelli 2012-03-12 13:55:51 UTC

>> 1) We no longer use "org.freedesktop.Telepathy.Client.KDE.TextUi" as the
>> handler identifier, use "org.freedesktop.Telepathy.Client.KTp.TextUi"
>> instead, same for filetransfer - replace "KDE" with "KTp" (and watch out for
>> the general capitalization, we use KTp, you use KTP sometimes) As for calls
>> (audio/video) - we currently don't really support calls; while it's cool to
>> have it ready, I'd comment it out for the time being.

> Nitpick - we should expose these values through constants or such in
> our public API, pretty much like tp-qt does. Magic strings in client
> applications are definitely not desirable.

I was thinking about some API in common-internals, that instead of 
having them as constant, make them configurable, defaulting to our 
components or to any other installed handler if our is not installed.
Even though there is no way to configure it (the only way is to edit 
manually the config file), the approver partially does that (see 
ktp-approver/src/handlewithcaller.cpp:38), we should move that in common 
and use it in every component (it would be great if we could do this in 
time for 0.4)

Comment 1 David Edmundson 2012-03-12 14:31:18 UTC

Just a quick note to whoever does this.

Do NOT update ktp-text-ui/app/chat-tab.cpp to use this.

ktp-text-ui/plasmoid/channel-delegator SHOULD be updated though

as should:
contact-list
krunner
ktp-send-file
the kipi plugin

Comment 2 George Kiagiadakis 2012-07-09 10:19:17 UTC

This will be solved by the so-called .desktop files.

11:13 < gkiagia> d_ed: I am thinking of doing .desktop files for all clients, even text-ui and call-ui
11:13 < gkiagia> this will also fix the capabilities issues
11:13 < d_ed> ok.
11:14 < gkiagia> right now we ask tp if we can handle incoming calls, where we need to ask it if we have call-ui installed
11:14 < d_ed> sure.
11:14 < d_ed> ok, and this is all integratable into the Contact List and Text-UI use cases?
11:14 < d_ed> seems good to me then.
11:15 < gkiagia> and all actions could come out of the client manager
11:15 < gkiagia> so that we don't have the same actions in many places

API draft:
http://quickgit.kde.org/index.php?p=clones%2Fktp-common-internals%2Fgkiagia%2Fktp-common-internals.git&a=shortlog&h=refs/heads/client-manager

Comment 3 David Edmundson 2013-01-18 22:28:21 UTC

Updating since we have a working hardcoded system for now.
(this also goes from a high priority bug to a task)