| Summary: | crash on adding new bookmark | ||
|---|---|---|---|
| Product: | [Unmaintained] rekonq | Reporter: | Heinz Wiesinger <pprkut> |
| Component: | general | Assignee: | Andrea Diamantini <adjam7> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | jmate31, metaxy, rodneyp |
| Priority: | NOR | ||
| Version: | 0.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.1 | |
| Sentry Crash Report: | |||
| Attachments: |
crash report
my crash report proposed fix crash report New crash information added by DrKonqi |
||
uhm... I cannot reproduce here. And this crash is really strange. Heinz, you can reproduce it with rekonq 0.9 compiled from "Branches.0.9" branch just adding a new bookmark (eg: clicking on the star on the urlbar)? I can confirm this bug. I compiled rekonq from Branches.0.9 and after adding some bookmarks it crashed. Hower it is not easy to reproduce because it seems to be random, e.g it does not crash for while, but short time after, every time I add a bookmark it does crash. Created attachment 69330 [details]
my crash report
Can you please test a patch for me, too better understand the problem? If you prefer a diff patch, I'm attaching it here. It should work in master and in Branches.0.9. If you prefer a git branch, it is 'Bug_295301_Proposed_Fix" on rekonq remote repo. Thanks. Created attachment 69488 [details]
proposed fix
Git commit ab7534b58128d99a0ec2cd77a981cba28d3df97b by Andrea Diamantini. Committed on 11/03/2012 at 10:11. Pushed by adjam into branch 'Bug_295301_Proposed_Fix'. Check WebTab::view() existence. I don't think this is needed in any way, according to code and docs. But same strange crashes (eg: bug 295301) suggest I'm wrong. This patch needs testing. M +5 -1 src/webtab.cpp M +7 -1 src/webtab.h http://commits.kde.org/rekonq/ab7534b58128d99a0ec2cd77a981cba28d3df97b Patch applied on top of Branches.0.9 and adding bookmarks works fine now :) Created attachment 69490 [details]
crash report
Hrm, did again crash :/
It was working for some pages now, so there might be still some improvement over the previous situation. New crash report attached.
Git commit f6cc2c5c13fbc219a6bc3391994b6cdeca44dd10 by Andrea Diamantini. Committed on 13/03/2012 at 00:23. Pushed by adjam into branch 'master'. Get sure urlbar(s) are deleted when related webtab is Heinz, Paul. Please test actual master before backporting this to 0.9 series. Many thanks for your help and for this bug report. I'm crossing fingers to hear good news from your tests ;) M +1 -1 src/mainview.cpp M +4 -2 src/urlbar/urlbar.cpp M +36 -0 src/webpage.cpp M +9 -29 src/webpage.h M +27 -9 src/webtab.cpp M +9 -12 src/webtab.h M +8 -7 src/webview.cpp M +1 -0 src/webview.h http://commits.kde.org/rekonq/f6cc2c5c13fbc219a6bc3391994b6cdeca44dd10 *** Bug 295894 has been marked as a duplicate of this bug. *** Git commit 707c0b1761e2823e4253bcb441a1a54478e5b76d by Andrea Diamantini. Committed on 13/03/2012 at 00:23. Pushed by adjam into branch 'Branches.0.9'. Get sure urlbar(s) are deleted when related webtab is Heinz, Paul. Please test actual master before backporting this to 0.9 series. Many thanks for your help and for this bug report. I'm crossing fingers to hear good news from your tests ;) M +1 -1 src/mainview.cpp M +4 -2 src/urlbar/urlbar.cpp M +36 -0 src/webpage.cpp M +9 -29 src/webpage.h M +27 -9 src/webtab.cpp M +9 -12 src/webtab.h M +8 -7 src/webview.cpp M +1 -0 src/webview.h http://commits.kde.org/rekonq/707c0b1761e2823e4253bcb441a1a54478e5b76d Any news here? Can someone of you reproduce bug in current master or Branches.0.9? Sorry, been busy this week. I'm running the version from Branches.0.9 for a couple days now and so far no crash. On Sun, 18 Mar 2012 05:26:20 Andrea Diamantini wrote:
> https://bugs.kde.org/show_bug.cgi?id=295301
> --- Comment #12 from Andrea Diamantini <adjam7@gmail.com> ---
> Any news here? Can someone of you reproduce bug in current master or
Branches.0.9?
Not readily. I was using the latest 0.9 available from repositories for
openSUSE 12.1. No updated app has been released there or in their
unstable branch.
Rod
You'll find it fixed in the upcoming 0.9.1 Created attachment 70003 [details]
New crash information added by DrKonqi
rekonq (0.9.0) on KDE Platform 4.8.1 (4.8.1) using Qt 4.8.0
- What I was doing when the application crashed: Pressing the back button the W key and the Command key on my Apple Keyboard.
- Unusual behavior I noticed: Closed unexpectedly.
- Custom settings of the application: None But I am Running and AMD 'DIY' setup that is 64-bit. And I am running Kubuntu 12.04 Beta 1 but I have upgraded it to Beta 2 since then.
-- Backtrace (Reduced):
#7 0x00007f8f50ea67a5 in page (this=0x2d1c4e0) at /build/buildd/rekonq-0.9.0-1/src/webtab.h:71
#8 WebTab::url (this=<optimized out>) at /build/buildd/rekonq-0.9.0-1/src/webtab.cpp:108
#9 0x00007f8f50ed5286 in UrlBar::loadFinished (this=0x2d20ee0) at /build/buildd/rekonq-0.9.0-1/src/urlbar/urlbar.cpp:354
#10 0x00007f8f50ed5da5 in qt_static_metacall (_a=<optimized out>, _id=<optimized out>, _o=<optimized out>, _c=<optimized out>) at /build/buildd/rekonq-0.9.0-1/obj-x86_64-linux-gnu/src/urlbar.moc:162
#11 UrlBar::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /build/buildd/rekonq-0.9.0-1/obj-x86_64-linux-gnu/src/urlbar.moc:151
|
Created attachment 69280 [details] crash report When adding a new bookmark, rekonq crashes after the bookmark is added (it's available after restarting rekonq). See attached crash report.