Bug 295214

Summary:	Edits to Image attachments from the Kmail composer window are not saved
Product:	[Applications] kmail2	Reporter:	Paul Worrall <p.r.worrall>
Component:	composer	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	montel, winter
Priority:	NOR
Version:	4.8
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	14.12	Version Fixed In:
Sentry Crash Report:

Description Paul Worrall 2012-03-02 15:09:10 UTC

Version:           4.8 (using KDE 4.8.0) 
OS:                Linux

When composing an email with an image attatchment, if I edit the image, save and close, then re-open the image, the original pre-edit image is shown.

Reproducible: Always

Steps to Reproduce:
1. Start a new message in Kmail and attach an image file (PNG or JPEG)
2. Right-click the attachment and choose Edit. (Image file opens in Gwenview)
3. Make a change to the image in Gwenview (e.g. Flip the image)
4. Save and close the image
5. Re-open the attachment from the Kmail composer window

Actual Results:  
The original image opens.

Expected Results:  
The changed image opens

Editing OpenOffice files and plain text files (using Kate) works as expected

Comment 1 Laurent Montel 2012-03-02 16:59:42 UTC

I confirm it.
don't know why it doesn't work.

Comment 2 Allen Winter 2012-06-08 23:15:32 UTC

I believe this has to do with the EditorWatcher (see messageviewer/editorwatcher.cpp)

In the EditorWatcher, we say that all image mimetypes are read-only.
same with pdfs.

I forget all the details of why we have an EditorWatcher.  Volker might remember.

Comment 3 Laurent Montel 2012-06-09 11:10:29 UTC

no it doesn't use a EditorWatcher for that.
It's a problem when we resave image.
I will investigate.

Comment 4 Paul Worrall 2013-06-15 06:05:13 UTC

This bug has got worse in Kmail 4.10.3:  Edits to text files are now not saved either.  Edits to LibreOffice attachments are still saved OK

Comment 5 Laurent Montel 2013-06-15 07:47:16 UTC

Will reinvestigate it

Comment 6 Laurent Montel 2014-12-05 16:02:12 UTC

I fixed it in 14.12.
Regards