Bug 295173

Summary:	Delete key should delete magnet links when the Magnet page has focus
Product:	[Applications] ktorrent	Reporter:	Tristan Miller <psychonaut>
Component:	general	Assignee:	Joris Guisson <joris.guisson>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/ktorrent/ed3d94b0247870c177b20e431286c4a4bfe320b6	Version Fixed/Implemented In:
Sentry Crash Report:

Description Tristan Miller 2012-03-01 20:17:05 UTC

Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

When the Magnet pane has focus and a magnet link is selected, pressing the Delete key on the keyboard should delete the Magnet link.  Currently it (rather unexpectedly, and somewhat dangerously) deletes whatever torrent is selected in the Torrent pane.

Reproducible: Always

Steps to Reproduce:
1. Open the "All Torrents" tab and select a torrent by left-clicking on it.
2. Open the Magnet pane and select a magnet link by left-clicking on it.
3. Press the Delete key on the keyboard.

Actual Results:  
4. The selected torrent is deleted,even though the Torrent pane doesn't have focus.

Expected Results:  
4. The selected magnet link should have been deleted, since the Magnet pane has focus.

This probably happens because the Delete key is not associated as a keyboard shortcut for the "Remove Magnet" command.

Comment 1 Tristan Miller 2012-03-01 20:17:49 UTC

Related to Bug 183417.

Comment 2 Joris Guisson 2012-04-29 08:19:04 UTC

Git commit ed3d94b0247870c177b20e431286c4a4bfe320b6 by Joris Guisson.
Committed on 29/04/2012 at 10:17.
Pushed by guisson into branch 'master'.

Delete key now also works in the MagnetView

M  +1    -0    ChangeLog
M  +12   -0    ktorrent/tools/magnetview.cpp
M  +2    -0    ktorrent/tools/magnetview.h
M  +12   -3    ktorrent/view/view.cpp
M  +1    -0    ktorrent/view/view.h

http://commits.kde.org/ktorrent/ed3d94b0247870c177b20e431286c4a4bfe320b6