Summary: | Sub sub-folders separated with '/' in file path cannot be created with album selection dialog [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Mathieu MD <mathieu> |
Component: | Import-Albums | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.steffan, alan.millen, antek88, caulier.gilles, dave, howerkraft, ianp, kde-bugs, kde, sf.rique, tpr, xstej70 |
Priority: | NOR | ||
Version: | 3.0.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/digikam/c28cd005a979aa4c3731c183ec6376707c10d5a8 | Version Fixed In: | 4.6.0 |
Sentry Crash Report: | |||
Attachments: |
Error popup
Implement subfolder creation for albums |
Description
Mathieu MD
2012-02-22 09:26:35 UTC
Created attachment 68999 [details]
Error popup
I too would like to use "yyyy/MM". I would like too see this too. As we have re-written a lots of code in Import tool this summer through GoSC 2012, The entry must be checked again with current digiKam 3.0.0-beta3 (not yet stable), at least to perform regression tests. Gilles Caulier Hello Gilles, I've just tested it with 3.0.0-beta3 and the error is still the same as in the attached example. I've just tested version 3.0.0 and the popup is the same. Still a problem in release 3.0. This folder structure is automatically created in Shotwell, Rapid Downloader, Picasa and others. People moving to Digikam from these want to maintain their structure. See also: http://sourceforge.net/tracker/?func=detail&aid=3610922&group_id=42641&atid=433763 Please report this sourceforge bug details in KDE bugzilla. We NEVER use SFbugtracker... Gilles Caulier *** This bug has been confirmed by popular vote. *** As a workaround until this gets fixed, you can actually make the import work by: 1. Create the empty folders tree in advance (by script or by hand) 2. Use double forward slash in the Check the Date format, e.g. to "yyyy//MM//dd" Hope this helps ease the pain. *** Bug 298035 has been marked as a duplicate of this bug. *** My comment from the another bug: Starting point for fixing this would be ImportUI::createSubAlbum(KUrl& downloadUrl, const QString& subalbum, const QDate& date) or createAutoAlbum() in the same class, in case support for folders should be wanted. I am using digikam 4.0.0 I have the same "problem" When i import images, i wont it to be organized like this: [Folder of year ] / [Folder of month] / [Folder of day ] / [ Picture of the day] An example would be like this: Took a picture 2014-12-25 named picture1.jpeg When i import the files i want it to be store in my albuns like this: /home/user/album/2014/12/25/picture1.jpeg As explained in the description: Reproducible: Always Steps to Reproduce: 1) Launch the Import Tool 2) Select photos 3) Check the "Date-based sub-albums" and set a Date format to "yyyy/MM/dd" 4) Click on the download button 5) A popup ask when you want to import the photo 6) Choose the album root folder Actual Results: An error popup says: Album name cannot contain '/'. (see attached capture) Expected Results: The subfolders needed by the imported photo should be created silently and corresponding photos imported into them. And as explained by Alan: As a workaround until this gets fixed, you can actually make the import work by: 1. Create the empty folders tree in advance (by script or by hand) 2. Use double forward slash in the Check the Date format, e.g. to "yyyy//MM//dd" But i guess is not pretty to have to create manually the folder to make it work So i guess would not be hard to fix, just check if there is a '/' and create folders if it does not exists. Thanks Created attachment 89714 [details]
Implement subfolder creation for albums
Here's a patch that implements the exact functionality requested. This is my first patch to the KDE bugtracker.
Git commit c28cd005a979aa4c3731c183ec6376707c10d5a8 by Teemu Rytilahti. Committed on 05/12/2014 at 14:49. Pushed by rytilahti into branch 'master'. ImportUI: Allow creation of subfolder when importing by creating parents recursively. Thanks for the patch Jimmy! M +2 -1 NEWS M +21 -4 utilities/importui/main/importui.cpp http://commits.kde.org/digikam/c28cd005a979aa4c3731c183ec6376707c10d5a8 |