| Summary: | Crash when switching from Icons View (with "Size" and "Date" as additional info) to Details View | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Frank Reininghaus <frank78ac> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | klangga |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Sentry Crash Report: | |||
|
Description
Frank Reininghaus
2012-02-20 22:28:58 UTC
Git commit abd23c29110560dd893e0dc2b542fd04e1845a0f by Peter Penz. Committed on 21/02/2012 at 16:46. Pushed by ppenz into branch 'KDE/4.8'. Don't trigger assert when switching to details-view If the visible roles of the details-view are equal to the visible roles of other views, then switching to the details-view will trigger an assert because the invisible roles don't get updated. Thanks to Frank Reininghaus for the detailed analyses! In the context of this fix optimizations have been done when switching view-modes: The "don't-animate-workaround" could be removed. FIXED-IN: 4.8.1 M +9 -5 dolphin/src/kitemviews/kfileitemlistview.cpp M +0 -3 dolphin/src/kitemviews/kfileitemlistview.h M +3 -0 dolphin/src/kitemviews/kfileitemmodel.cpp M +7 -18 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp M +10 -1 dolphin/src/kitemviews/kitemlistview.cpp M +9 -1 dolphin/src/kitemviews/kitemlistview.h M +0 -17 dolphin/src/views/dolphinview.cpp http://commits.kde.org/kde-baseapps/abd23c29110560dd893e0dc2b542fd04e1845a0f Git commit ac818a140ed36fe0322f4004247c5dfd51c05f49 by Peter Penz. Committed on 21/02/2012 at 16:46. Pushed by ppenz into branch 'master'. Don't trigger assert when switching to details-view If the visible roles of the details-view are equal to the visible roles of other views, then switching to the details-view will trigger an assert because the invisible roles don't get updated. Thanks to Frank Reininghaus for the detailed analyses! In the context of this fix optimizations have been done when switching view-modes: The "don't-animate-workaround" could be removed. FIXED-IN: 4.8.1 M +9 -5 dolphin/src/kitemviews/kfileitemlistview.cpp M +0 -3 dolphin/src/kitemviews/kfileitemlistview.h M +3 -0 dolphin/src/kitemviews/kfileitemmodel.cpp M +7 -18 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp M +10 -1 dolphin/src/kitemviews/kitemlistview.cpp M +9 -1 dolphin/src/kitemviews/kitemlistview.h M +0 -17 dolphin/src/views/dolphinview.cpp http://commits.kde.org/kde-baseapps/ac818a140ed36fe0322f4004247c5dfd51c05f49 *** Bug 291631 has been marked as a duplicate of this bug. *** |