Bug 294108

Summary: Massif-visualiser can't parse heap sizes above 4 GB
Product: [Frameworks and Libraries] massif-visualizer Reporter: Mihai Basa <mihaibasa>
Component: massif-parserAssignee: Massif Visualizer developers <massif-visualizer>
Status: RESOLVED FIXED    
Severity: normal    
Priority: VHI    
Version: master   
Target Milestone: 0.2   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Mihai Basa 2012-02-14 22:05:00 UTC 
Version:           master (using KDE 4.7.4) 
OS:                Linux

When trying to open massif.out files that involve values of mem_heap_B larger than 4GB, an error message of this sort is produced:

Could not parse file /home/user/path/massif.out.32406.
Parse error in line 16:
mem_heap_B=5012345678

A series of datatypes need to be changed to long long ints, or something of the sort, I imagine.

Reproducible: Always

Steps to Reproduce:
In the test file massif.out.32406, change 100 to 5021305210.


Expected Results:  
Should parse.
Comment 1 Milian Wolff 2012-02-15 10:27:23 UTC 
confirmed, I'll adapt the api to use quint64 - that should be enough :)
Comment 2 Milian Wolff 2012-02-16 22:42:40 UTC 
Git commit 24d842b47d7afcf59856178a0dc246f1cd5bb00f by Milian Wolff.
Committed on 16/02/2012 at 23:40.
Pushed by mwolff into branch 'master'.

use quint64 for bytesizes to support memory > 4GB

M  +1    -1    app/mainwindow.cpp
M  +4    -4    massifdata/parserprivate.cpp
M  +9    -9    massifdata/snapshotitem.cpp
M  +13   -13   massifdata/snapshotitem.h
M  +2    -2    massifdata/treeleafitem.cpp
M  +3    -3    massifdata/treeleafitem.h
M  +19   -0    test/datamodeltest.cpp
M  +1    -1    test/datamodeltest.h
M  +1    -1    visualizer/detailedcostmodel.cpp
M  +10   -9    visualizer/dotgraphgenerator.cpp
M  +3    -3    visualizer/dotgraphgenerator.h
M  +1    -1    visualizer/util.cpp
M  +1    -1    visualizer/util.h

http://commits.kde.org/massif-visualizer/24d842b47d7afcf59856178a0dc246f1cd5bb00f